Re: Can you spot anything wrong with this class/structure?

From:

Clark Cox <clarkcox3@gmail.com>

Newsgroups:

comp.lang.c++

Date:

Sat, 1 Dec 2007 18:20:33 -0800

Message-ID:

<2007120118203316807-clarkcox3@gmailcom>

On 2007-12-01 16:42:01 -0800, "Jim Langston" <tazmaster@rocketmail.com> said:

Ooops, you're right, missed those.

struct JVEC2
{
    JVEC2(float x=0,float y=0): x(x), y(y) {}
    // Supported operators
    JVEC2 operator+(const JVEC2& a) const { return JVEC2( x + a.x, y +
a.y ); }
    JVEC2 operator-(const JVEC2& a) const { return JVEC2( x - a.x, y -
a.y ); }
    JVEC2 operator*(const JVEC2& a) const { return JVEC2( x * a.x, y *
a.y ); }
    JVEC2 operator/(const JVEC2& a) const { return JVEC2( x / a.x, y /
a.y ); }
    JVEC2 operator+(float a) const { return JVEC2( x + a, y + a ); }
    JVEC2 operator-(float a) const { return JVEC2( x - a, y - a ); }
    JVEC2 operator*(float a) const { return JVEC2( x * a, y * a ); }
    JVEC2 operator/(float a) const { return JVEC2( x / a, y / a ); }
    JVEC2& operator+=(const JVEC2& a) {x += a.x;y += a.y;return *this;}
    JVEC2& operator*=(const JVEC2& a) {x *= a.x;y *= a.y;return *this;}
    JVEC2& operator-=(const JVEC2& a) {x -= a.x;y -= a.y;return *this;}
    JVEC2& operator/=(const JVEC2& a) {x /= a.x;y /= a.y;return *this;}
    JVEC2& operator+=(float a) {x += a;y += a;return *this;}
    JVEC2& operator-=(float a) {x -= a;y -= a;return *this;}
    JVEC2& operator*=(float a) {x *= a;y *= a;return *this;}
    JVEC2& operator/=(float a) {x /= a;y /= a;return *this;}
    bool operator == (const JVEC2& a) const {if (x == a.x && y == a.y)
return true; else return false;}
    bool operator != (const JVEC2& a) const {if (x != a.x || y != a.y)
return true; else return false;}

These operators are written a little strangely, if I were writing them, I'd do:
bool operator==(const JVEC2& a) const { return (x == a.x && y == a.y); }
bool operator!=(const JVEC2& a) const { return !operator==(a); }

JVEC2 operator + () const {return JVEC2( +x, +y ); }

For this, I'd just do:
JVEC2 operator + () const { return *this; }

    JVEC2 operator - () const {return JVEC2( -x, -y ); }
    // data
    float x,y;
};

--
Clark S. Cox III
clarkcox3@gmail.com