Re: Crash on erase() - *not* in a loop

Hi,

I'm confused about a persistent crash when using STL containers. I call
erase() and the program crashes in either _Orphan_range or _Orphan_ptr
depending on which class I try.

I've used map, hash_map and vector all with the same results. The DLL is
multi-threaded, but all list access is protected using
Enter/LeaveCriticalSection.

I'm *not* iterating through a loop!

The STL class definition is:

class PatchedFileInfo
{
...
};

typedef std::vector<PatchedFileInfo> FHList;
FHList PatchedList;

The insert code for vector<> is:

EnterCriticalSection(&ListAccess);
PatchedList.push_back(PatchedFileInfo(FileHandle[0],asciiFileName));
LeaveCriticalSection(&ListAccess);

I also tried this for map and hash_map:

EnterCriticalSection(&ListAccess);
PatchedList[FileHandle[0]].Filename = asciiFileName;
LeaveCriticalSection(&ListAccess);

The erase() code, which crashes, is:

EnterCriticalSection(&ListAccess);
FHList::iterator i = PatchedList.find(Handle);
if (i != PatchedList.end()) {
  // Matched.
  Log(i->second);
  PatchedList.erase(i);
}
LeaveCriticalSection(&ListAccess);

I repeat, this is not in a loop and the iterator is not accessed after
it has been deleted.

I've rebuilt dozens of times, checked that all modules are using the
same libraries, stepped through the STL libraries etc. It's going wrong
inside the erase() code; the list of _Nextiter pointers is fine up until
it hits the _Orphan_ptr code. Then, the last element gets corrupted.

If I check the list of _Nextiter pointers for 'i' it's fine. The Log()
call is fine, it shows the correct value. The internal values in the
erase() call are fine - right up until _orphan_XXXX is called.

Any ideas? Using VC2005 on x64 with the Windows 6.1 includes.

Thanks,
Jim