Re: Cannot seem to lock HashMap
byo...@hotmail.com wrote:
Basically the situation is that I have a HashMap (yes I know this is
not synchronized and therefore must do it manually). The HashMap is
used by two threads running concurrently, and one thread is adding
values to the map while the other is iterating over the values. Now
typically I would expect to get the ConcurrentModificationException -
but I have tried to synchronize the object manually without any luck.
Perhaps I don't understand locking, but according to Java 1.5 API this
Rather than "locking" you should be thinking "synchronization".
should work, I wrote the following test class to demonstrait what I am
trying to do:
What are you trying to do? It's not clear from the code.
import java.util.Collections;
import java.util.Date;
import java.util.HashMap;
import java.util.Map;
public class TestIndex {
public static HashMap<Date, Date> values = new HashMap<Date, Date>();
public static void main(String[] args) {
new Thread_1().start();
new Thread_2().start();
}
public static class Thread_1 extends Thread {
public Thread_1() {
super("Thread_1");
this.setDaemon(false);
}
public void run() {
System.out.println("Thread_1 run...");
try {
for (int i=0; i<1000000; i++) {
TestIndex.values.put(new Date(),new Date());
}
Nothing is synchronized here.
} catch (Exception e) {
e.printStackTrace();
}
System.out.println("Thread_1 END");
}
}
public static class Thread_2 extends Thread {
public Thread_2() {
super("Thread_2");
this.setDaemon(false);
}
public void run() {
System.out.println("Thread_2 run...");
try {
for (int i=0; i<1000000; i++) {
Map m = Collections.synchronizedMap(TestIndex.values);
synchronized (m) {
HashMap<Date, Date> newMap = new HashMap<Date, Date>(m);
}
OK, here you create a Map from your "values" Map a million times, doubly
synchronized (?) and copied into another Map, which latter is then discarded.
}
} catch (Exception e) {
e.printStackTrace();
}
System.out.println("Thread_2 END");
}
}
}
Your Thread_2 class creates a million copies of your values Map, possibly at
various stages of its population with values, inside a synchronized block that
synchronizes on a synchronized Map.
What are you really trying to do?
--
Lew