Re: Disable button

From:

Fencer <no.i.dont@want.mail.from.spammers.com>

Newsgroups:

comp.lang.java.programmer

Date:

Tue, 08 Sep 2009 15:50:14 +0200

Message-ID:

<7gn5oqF2o19avU1@mid.individual.net>

Fencer wrote:

Hello, I have a button (JButton) in a dialog (JDialog) that should be
disabled if there's nothing entered in a particular textfield.

I solved that by creating this little class that implements the
DocumentListener interface:

class ButtonEnablerDisabler implements DocumentListener {

    ButtonEnablerDisabler(JButton button) {
        this.button = button;
    }


    public void changedUpdate(DocumentEvent e) {
        button.setEnabled(e.getDocument().getLength() > 0);
    }

    public void insertUpdate(DocumentEvent e) {
        button.setEnabled(e.getDocument().getLength() > 0);
    }


    public void removeUpdate(DocumentEvent e) {
        button.setEnabled(e.getDocument().getLength() > 0);
    }


    private JButton button;
}

and then I simply do:
myTextField.getDocument().addDocumentListener(new
ButtonEnablerDisabler(myButton));

it seems to work fine. Now my problem is this...I actually have four
text fields and the button shouldn't be enabled unless there's text in
all four.
My first attempt was silly: I simply repeated the line of code above for
all text fields, but that doesn't work because then you can enable the
button even if there's no text in the other fields. How should I solve
this problem?

I wrote this solution which I'm going to go with until I find a better
one (it's not robust or elegant):

class ButtonEnablerDisabler implements DocumentListener {

    ButtonEnablerDisabler(JButton button, int index, boolean initialState) {
        this.index = index;
        this.button = button;

        ButtonEnablerDisabler.allSet[index] = initialState;
    }

    public void changedUpdate(DocumentEvent e) {
        allSet[index] = e.getDocument().getLength() > 0;
        button.setEnabled(shouldEnable());
    }

    public void insertUpdate(DocumentEvent e) {
        allSet[index] = e.getDocument().getLength() > 0;
        button.setEnabled(shouldEnable());
    }

    public void removeUpdate(DocumentEvent e) {
        allSet[index] = e.getDocument().getLength() > 0;
        button.setEnabled(shouldEnable());
    }

    private boolean shouldEnable() {
        for (boolean b : ButtonEnablerDisabler.allSet) {
            if (!b) {
                return false;
            }
        }

        return true;
    }

    private JButton button;
    private int index;

    private static boolean[] allSet = new boolean[]{false, false, false,
false};
}

Document doc = firstTextField.getDocument();
doc.addDocumentListener(new ButtonEnablerDisabler(button, 0,
doc.getLength() > 0));

doc = secondTextField.getDocument();
doc.addDocumentListener(new ButtonEnablerDisabler(button, 1,
doc.getLength() > 0));

doc = thirdTextField.getDocument();
doc.addDocumentListener(new ButtonEnablerDisabler(button, 2,
doc.getLength() > 0));

doc = fourthTextField.getDocument();
doc.addDocumentListener(new ButtonEnablerDisabler(button, 3,
doc.getLength() > 0));

- Fencer