Re: CToolBarCtrl::GetButtonInfo Bug?

From:

=?Utf-8?B?VC4gRm9yZA==?= <TFord@discussions.microsoft.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Tue, 30 Oct 2007 12:44:00 -0700

Message-ID:

<51684735-E78A-4B03-BE3D-A62E4D40A971@microsoft.com>

"David Lowndes" wrote:

Doing a little more research, I've found the problem.
CToolBarCtrl::GetButtonInfo looks like this:

_AFXCMN_INLINE BOOL CToolBarCtrl::GetButtonInfo(int nID, TBBUTTONINFO*
ptbbi) const
{ ASSERT(::IsWindow(m_hWnd)); return (BOOL) ::SendMessage(m_hWnd,
TB_GETBUTTONINFO, nID, (LPARAM)ptbbi); }

The TB_GETBUTTONINFO msg returns a 0 based index. Whoever wrapped that
message for this class incorrectly decided to cast the result to a BOOL, so
that valid 0 index is returned as FALSE. So the only way to accurately
handle this is to not use the GetButtonInfo method, and just send the msg
yourself.

Torin,

Could you submit a bug report for your findings on the connect web
site. As you say, it clearly looks wrong. I can't see any evidence of
anyone else submitting a report on this, so MS are probably unaware of
it.

So as not to lose this, I've submitted a bug report:

https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=306903

Dave

Dave,
Thanks. I stil haven't yet figured out how to get "posting" permissions
for any of the connections on connect.microsoft.com. I have a valid account
but thats about all I have so far. :-)

Torin