Re: Non-modal dialog pParent initialization (and warning C4355)
On Mar 22, 7:14 am, "Doug Harrison [MVP]" <d...@mvps.org> wrote:
On 22 Mar 2007 01:11:46 -0700, "Harvey" <harve...@juno.com> wrote:
On Mar 21, 8:26 pm, "Doug Harrison [MVP]" <d...@mvps.org> wrote:
On 21 Mar 2007 13:44:26 -0700, "Harvey" <harve...@juno.com> wrote:
How did I change the signature? If I remember correctly (and typed it
correctly), this is the way the wizard wrote it. I only put the line
in the body. (But that was 11 days ago :-> ).
You tell me. :) I'm going by the documentation:
CDialog::Createhttp://msdn2.microsoft.com/en-us/library/yhth57kd(VS.80).aspx
<q>
virtual BOOL Create(
LPCTSTR lpszTemplateName,
CWnd* pParentWnd = NULL
);
virtual BOOL Create(
UINT nIDTemplate,
CWnd* pParentWnd = NULL
);
</q>
Did the wizard really create a new function in your derived class named
Create with signature:
BOOL CFooDlg::Create(CWnd * pParent)
{
pCV=(CMyBar *) pParent;
}
Note also that it's bad to overload virtual functions as CDialog does with
Create, but this wasn't too evident 15 years ago when MFC was being
written. Just avoid doing it in new code.
--
Doug Harrison
Visual C++ MVP
Oh, now that I go actually look at the code... :)
Well, you are quite right.
I have this in several Dialogs, I obviously copied the bad code from
one class to another several times. Now I see that the signature is
not the same as even the base class that the function calls. So I
guess I better go fix them all :-)
Thanks for your help - it's much appreciated.
Harvey
You're welcome. In case it isn't clear, I said it's bad to overload virtual
functions because to get Create to do your thing no matter which overload
is called, you have to override all the overloads.
--
Doug Harrison
Visual C++ MVP
Yes, I can see what you mean. So I scrapped the Create() functions in
my app and used the class wizard generated WM_CREATE handler which is
OnCreate() instead. The idea is the same as in my original post
(method 1) but hopefully it is correct. Here is the code from one of
my six Non-modal dialogs. what do you think? Can it be improved?
Thanks Doug,
Harvey
// CMultDlg dialog
// CMultDlg is a NON-modal Dialog Box
CMultDlg::CMultDlg(CWnd* pParent /*=NULL*/)
: CDialog(IDD, pParent)
{
// pParent is not set here for NON-modal dialog, See OnCreate()
pCV = NULL;
//{{AFX_DATA_INIT(CMultDlg)
// NOTE: the ClassWizard will add member initialization here
//}}AFX_DATA_INIT
}
int CMultDlg::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
if (CDialog::OnCreate(lpCreateStruct) == -1)
return -1;
pCV = (CChildView *)FromHandlePermanent(lpCreateStruct->hwndParent);
return 0;
}