Re: inconsistencies when compiling
On Jan 25, 12:01 pm, "Alf P. Steinbach" <al...@start.no> wrote:
* James Kanze:
On Jan 24, 12:53 pm, "Alf P. Steinbach" <al...@start.no> wrote:
* rory:
I'm having some inconsistencies in my program that I can't seem to
debug. Below is code that makes a copy of a binary file, appends a
unique ID and string to the copy of the binary file and then checks
^^^^^^
[...]
//read contents of input file
ifstream file(argv[1]);
He doubtlessly needs to specify binary mode. (In a larger
application, he' probably want to imbue the "C" locale as well.)
I don't think binary mode is intended, because he treats the
file as a text file, using std::getline.
That's true, but he does SAY binary. I'm supposing that getline
is the error, but of course, we don't really know.
And as we know, this is NOT the way to read all of a file.
Yes, I commented on that two lines further down in the code, at the
unchecked call to std::getline.
Fixing that call would lead to fixing the loop condition as well.
If he fixes it correctly, yes. It depends on how he fixes it.
I'm really thinking that someone should write up a beginner's
guide to using iostream, with the standard idioms, and post it
somewhere so we could point to it.
--
James Kanze (GABI Software) email:james.kanze@gmail.com
Conseils en informatique orient=E9e objet/
Beratung in objektorientierter Datenverarbeitung
9 place S=E9mard, 78210 St.-Cyr-l'=C9cole, France, +33 (0)1 30 23 00 34