Re: trouble with STL list initialization inside nested structure

From:

SG <s.gesemann@gmail.com>

Newsgroups:

comp.lang.c++

Date:

Wed, 30 Sep 2009 00:14:37 -0700 (PDT)

Message-ID:

<9afd8995-759f-45fa-a1ef-89667cb232e3@j19g2000yqk.googlegroups.com>

M A wrote:

typedef struct {
list<struct row> bm;
vector<struct row> vbm;

} MyStruct;

This is a mixture of C and C++. You could write just as well

  struct MyStruct {
      list<row> bm;
      vector<row> vbm;
  };

typedef struct pattern {
int nodenum; // unique in the graph
MyStruct ms;
} TP;

same here

int main(int args, char **argv)
{
        TP *tp = (TP *) malloc (sizeof(TP));
        struct row r1 = {1, (char *)"xyz"};
        tp->ms.bm.push_back(r1);
}

same here. Replace malloc with new and char* with std::string. Also, I
don't see a reason for using the free store. This should work too:

  int main(int args, char **argv)
  {
     TP tp;
     row r1 = {1, "xyz"}; // note: no "struct" prefix
     tp.ms.bm.push_back(r1);
  }

By the way: In C++ string literals are const. So, you better use
"const char*" instead of "char*". The latter one still compiles for
backwards compatibility to C. Since you're now allowed to modify the
characters of a string literal (not even in C) you'll only gain from
using const qualifiers here.

One last note: Try to improve encapsulation.

Cheers,
SG