Re: catch exception

From:

red floyd <redfloyd@gmail.com>

Newsgroups:

comp.lang.c++

Date:

Fri, 22 Aug 2008 14:41:28 -0700 (PDT)

Message-ID:

<988b9c3b-e800-4b7b-88b9-c694a991e917@m44g2000hsc.googlegroups.com>

On Aug 22, 2:15 pm, junw2...@gmail.com wrote:

class A
{
public:
    A()
    {
         try
         {
               p = new int;
               //Other lines that may throw exception.
         }
         catch(...)
         {
               delete p;
         }

private:
     int *p;

};

In the above code, catch the exception in A's constructor to delete p.
Is it OK? Is there a better way to delete p?

Yes it's OK (modulo the missing closing brace), but better is:

class A
{
public:
    A() : p(new int(0))
    {
       // do other stuff which may throw
    }

private:
     some_smart_pointer_type<int> p;

};

Now if that stuff throws, the smart pointer for p will be destroyed,
which will delete p.
Pick your smart pointer -- see boost and tr1. Or, if you know this
object won't be getting copied, or you have a deep copy constructor,
you could use std::auto_ptr