Re: Strange result
Hi,
Alf P. Steinbach wrote:
1. The program below should theoretically not run on my old & clunky
machine,
since theoretically it allocates 2 to 4 GB. In reality, according to
Windows
Task Manager, it allocates only some 20 MB tops. And runs fine, though
slow...
2. With MSVC, and/or with 10.000 or fewer iterations and Op vector
elements, the inefficient reference strings are faster than std::string
string, as expected. On my machine, with g++ and 100.000 iterations, the
opposite happens, and the
machine trashes on allocation and deallocation for the ref strings. I
guess on a modern machine that limit must be higher (yet another factor of
10?), but I'm interested whether (1) this can be reproduced, and (2)
whether anyone has any explanation (at a guess something causes a lot of
memory to be allocated, but it doesn't show up in Task Manager).
I think you're missing copy constructors, see below:
Disclaimer: this is late for me, so thinking box not entirely sharp...
#include <boost/progress.hpp>
#include <boost/shared_ptr.hpp>
#include <iostream>
#include <ostream>
#include <vector>
#include <string>
class RefString
{
private:
boost::shared_ptr<std::string> myString;
public:
RefString( size_t n, char c )
: myString( new std::string( n, c ) )
{}
// Missing copy constructor for non-PODs:
RefString(const RefString &s)
: myString(s.myString)
{ };
RefString &operator=(const RefString &s)
{ myString = s.myString; return *this; };
};
template< class String >
struct Op_
{
String s;
std::vector<String> v;
Op_(): s( 200, ' ' ), v( 100, s ) {}
// Missing copy constructor for non-PODs:
Op_(const Op_ &o)
: s(o.s), v(o.v) { };
Op_ &operator=(const Op_ &o)
{ s = o.s; v = o.v; return *this; };
void operator()() { v.insert( v.begin(), s ); }
};
template< class String >
void doTest()
{
using namespace std;
typedef Op_<String> Op;
vector<Op> op( 100000 );
boost::progress_timer timer;
for( size_t i = 0; i < op.size(); ++i )
{
op[i]();
}
}
template< class String >
void doNamedTest()
{
std::cout << typeid(String).name() << ": ";
doTest<String>();
}
int main()
{
for( int i = 1; i <= 5; ++i )
{
std::cout << "TEST #" << i << ":" << std::endl;
std::cout << std::endl;
doNamedTest<RefString>();
doNamedTest<std::string>();
}
}
HTH,
Paul