Re: Is this valid and moral C++?

From:

"Jim Langston" <tazmaster@rocketmail.com>

Newsgroups:

comp.lang.c++

Date:

Fri, 23 Mar 2007 23:48:10 -0700

Message-ID:

<PQ3Nh.343$0s2.220@newsfe02.lga>

"Filimon Roukoutakis" <filimon@phys.uoa.gr> wrote in message
news:eu0b95$h0k$1@cernne03.cern.ch...

Filimon Roukoutakis wrote:

Suppose that we have a function

f(Object*& obj)

and have declared a global std::vector<Object*> vec;

Is it valid to do

void g() {
vec.push_back(new Object);
f(vec.back());
}

ie does f() internally actually have read/write access to the Object
allocated in g() on the heap? If not, what would be the trick to achieve
this? Thanks,

filimon

Problem solved. The problem was that the above code produced a
segmentation violation in another part of the program. The fix was to
replace std::vector<Object*> with std::vector<Object**> and
vec.push_back(new Object*). Probably this was not obvious in the context
of the code snippet that was presented here. Thanks for the answers.

std::vector<someclass*> is usually bad design unless you are working with
polymorphism. Even then some would say use a smart pointer (although I use
naked pointers myself).

std::vector<someclass**> I could only think is bad design. You may want to
relook at what you are doing and see if this is absolutly necessary, it
sounds like a maintainance nightmare.