Re: What's wrong with this class
peter koch a ?crit :
On 24 Okt., 20:05, Mosfet <mos...@anonymous.org> wrote:
Obnoxious User a ?crit :
On Fri, 24 Oct 2008 18:14:35 +0200, John Doe wrote:
Obnoxious User wrote:
[snip]
How many times is this function called in your test case? Most probably
two times, right?
And what does it do each time?
[snip]
void OnGettingNetworkList()
{
NetworkList netList = getNetworkList();
}
You return a *copy* of the NetworkList you build in the function. The
first copy dies and deallocates via Clear() all the pointers so the
copy contains invalid pointers, which are deallocated yet again, that's
where the CString fails it assertions, becuase it is already destroyed.
yes thanks!!!! I knew it was something like that but I couldn't find it.
How can I solve this ? If I remove my Clear() method how can I be sure
that when netList is destroyed, there is no memory leak ?
You're missing a proper copy constructor.
Finally I am using getNetworkList like this :
void getNetworkList(NetworkList& netList)
{
...
}
getNetworkList(m_NetworkList);
and now it works fine.
No it isn't. Not unless you do a fair deal of work in the function (a
deep copy), and in that case, you might just as well have followed my
advice in the first place.
If I knew what you mean I won't be posting here
Maybe it doesn't work but my application seems ok!
I forgot to say now getNetworkList is now declared to take a reference
on a NetworkList so there is no copy anymore.
:
void getNetworkList(NetworkList& netList)
{
GUID guid;
netList.Add(new Network(_T("Network1"), guid));
netList.Add(new Network(_T("Network2"), guid));
}
However now that I have added const everywhere I cannot even do this :
CString strTmp = pNetwork->getName();
or LPCTSTR szName = pNetwork->getName();
That's why I think const brings more issues than it solves ...
That is because you have put your consts in the wrong places or
because CString is broken with respect to constness - I don't really
know that class. Why dount you simply use std::wstring?
/Peter
Same issue with std::wstring..
const Network* pNetwork = m_NetworkList.getNetwork(lpAttrVal);
const std::wstring& strTmp = pNetwork->getName();
error C2662: 'Network::getName' : cannot convert 'this' pointer from
'const Network' to 'Network &'