Re: removing from set - does it have to be so ugly?

From:

Yechezkel Mett <ymett.on.usenet@gmail.com>

Newsgroups:

comp.lang.c++.moderated

Date:

Thu, 12 Nov 2009 07:27:06 CST

Message-ID:

<e44309d9-173b-4df8-8abf-00605e76ab59@p35g2000yqh.googlegroups.com>

On Nov 12, 10:47 am, Alfons <alfonsvanwor...@gmail.com> wrote:

std::set<Stuff>::iterator current_item( stuff_set.begin() );
while ( current_item != stuff_set.end() )
{
        if ( is_bad( *item ) )
        {
                std::set<Stuff>::iterator previous_item( --current_item );
                stuff_set.erase( ++current_item );
                current_item = previous_item;
        }
        ++current_item;

}

Is this the best way I can structure this? I hate writing code like
this :(

  while ( current_item != stuff_set.end() )
          if ( is_bad( *item ) )
                  current_item = stuff_set.erase( current_item );
          else
                  ++current_item;

or alternatively:

stuff_set.erase( std::remove_if( stuff_set.begin(), stuff_set.end(),
is_bad ),
         stuff_set.end() );

Yechezkel Mett

--
      [ See http://www.gotw.ca/resources/clcm.htm for info about ]
      [ comp.lang.c++.moderated. First time posters: Do this! ]