Re: Loop generates never-ending sockets and threads, need help debugging

Hi all,

I have a client/server project written by a hired contractor, but it's got a fairly big bug when it comes to dealing with thread and sockets. It creates threads but never closes the handle to them, thus causing the server to accumulate hundreds of thousands of open handles in a day or so. The client and server both share similar code, but I'll just post the server-side.

     while (blStarted) {
        SOCKET sa = accept(socCommand, 0, 0); // block for connection request
        if (sa ==INVALID_SOCKET) {
            break;
        }
        void **params = (void **) malloc(sizeof(void*)*2);
        SOCKET *s = new SOCKET;
        *s = sa;
        params[0] = (void*)this;
        params[1] = (void*)s;
        DWORD dwGenericThread;
        //unsigned int iGenericThread;
        HANDLE hWorkerThread = CreateThread(NULL, 0, transferCommandWorkerThread, params, 0, &dwGenericThread);
        //HANDLE hWorkerThread = (HANDLE)_beginthreadex(NULL, 0, transferCommandWorkerThread, params, 0, &iGenericThread);
        //WaitForSingleObject(hWorkerThread, INFINITE);
        //CloseHandle(hWorkerThread);
    }
}