Re: Database helper class with PreparedStatements

From:

"teser3@hotmail.com" <teser3@hotmail.com>

Newsgroups:

comp.lang.java.programmer

Date:

Sat, 10 Nov 2007 15:28:28 -0800

Message-ID:

<1194737308.722535.320200@v3g2000hsg.googlegroups.com>

Thanks for your quick response.

Would this be better where I put the Connection and PreparedStatement
instances in the method??

public class DbWork
{
      public void cityInserter(FormBean city) throws SQLException
      {
         Connection connection = ConnectionMgr().getConnection();
         PreparedStatement stat = connection.prepareStatement("Insert
into City (street, school) values (?,?)");
         stat.setString(1, city.getStreet());
         stat.setString(2, city.getSchool());
         stat.executeUpdate();
     }

    public void dbMethod(FormBean city)
    {
         try
        {
                cityInserter(city);
        }
        catch(SQLException ex)
        {
               System.out.println(ex);
        }
       finally
        {
              connection.close();
//not sure if I corrected this issue here or not??

The problem here is that connection is part of the instance, and created
during construction, but you close() it before the object is disposed. This
leaves the possibility of client code attempting to re-use the object after
the connection has been closed.

}
}