Re: correct usage for @SuppressWarnings("unchecked")
On 4/19/2010 9:19 AM, Thufir wrote:
I'm just going through and ensuring compilation with -Xlint and find
myself assuming that the cast will work -- which it currently does.
Should it be wrapped in a try/get? A more sophisticated use of
generics?
package view;
import database.*;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
public class BeatlesLoader {
private Logger logger =
Logger.getLogger(view.BeatlesLoader.class.getName());
private ParametersBean mp = new ParametersBean();
public BeatlesLoader() {
logger.log(Level.INFO, "BeatlesLoader...");
}
@SuppressWarnings("unchecked")
private List<Beatle> populateBeatles() {
logger.log(Level.INFO, "populateBeatles...");
database.DatabaseBean database = new database.DatabaseBean();
ArrayList<ArrayList<String>> table = database.getTable();
List<Beatle> beatles = new ArrayList<Beatle>();
for (ArrayList record : table) {
Beatle beatle = new Beatle(record);
beatles.add(beatle);
}
logger.log(Level.INFO, "...populateBeatles" +
beatles.toString());
return beatles;
}
public List<Beatle> getBeatles() {
logger.log(Level.INFO, "getBeatles...");
List<Beatle> beatles = populateBeatles();
logger.log(Level.INFO, "...getBeatles" + beatles.toString());
return beatles;
}
}
thanks,
Thufir
A few things here... Try to put the @SuppressWarnings annotation as
close as possible to the line which causes the problem.
I'm not entirely sure which line is causing the problem. Perhaps it is
the for() loop, which should be for(ArrayList<String> record : table)
instead.
Also, if I were desiginging the DatabaseBean class, I would make
getTable() return List<? extends List<String>>
Actually, looking at what you are doing, it might make more sense for
you to look into using an existing ORM, rather than writing your own
Database abstraction. Hibernate is a popular open-source ORM.
--
Daniel Pitts' Tech Blog: <http://virtualinfinity.net/wordpress/>