"Arne Vajh?j"<arne@vajhoej.dk> wrote in message
news:4c005ae9$0$281$14726298@news.sunsite.dk...
On 28-05-2010 19:02, Rhino wrote:
It's the if statement that concerns me here. This code works fine (I can
test for CompletionStatus.NO_ERROR by simply changlng the right side of
the
if) but it doesn't look right. It reminds me of mistakes I made when I
was
new to Java comparing Strings to each other via the == operator to see if
they had the same VALUE but discovering that == doesn't determine
equality
of value.
Is there a better way to do this if statement? If so, what is it?
I would compare with CompletionStatus.NO_ERROR, because it is
a lot more likely that you will have more than one error status
than more than one no error status.
Okay, that's fair. But am I writing the comparison correctly? That ==
operator looks wrong somehow, even if it works. I'm concerned that this
might be like comparing two Strings with the == operator; sometimes it will
show equality and make you think it is confirming equality of value between
the two strings but it is not; you have to use equals() to compare String
values. But I'm not sure what the equivalent is for an enum.
== on enums are fine.
Object identity is exactly what is needed.