Re: File is null when downloaded from unix

From:

"Guan" <dontmailmi@gmail.com>

Newsgroups:

comp.lang.java.programmer

Date:

8 Nov 2006 08:11:55 -0800

Message-ID:

<1163002315.447161.60150@f16g2000cwb.googlegroups.com>

Hi,

Thanks for all of you for your time for reading my posting and giving
comments

I hope the following code is sufficient for you. THis the not the full
program it is the downloading part as the whole program is quite long

I am using netcomponents FTP class to retrive file from FTP server, I
tested this code to retrive file From FTP running on windows platform
and it seem ok.. Howerver when i tried to retrieve file from ftp server
on unix plaform. The file i download is empty content

==========================================================
ftp = new FTPClient();
           ftp.connect(FTP_SERVER);
           int reply = ftp.getReplyCode();
           if
(!com.oroinc.net.ftp.FTPReply.isPositiveCompletion(reply))
               throw new java.io.IOException("Could not connect to ftp
server " +
                                             FTP_SERVER);
           ftp.login(ftpUserId, ftpPassword);
           ftp.setFileType(com.oroinc.net.ftp.FTP.BINARY_FILE_TYPE);
           ftp.changeWorkingDirectory(ftp.printWorkingDirectory());
           try {

           // Retrieve the file
           response.setHeader("Content-Type",
"application/x-download");
           response.setHeader("Content-Disposition","attachment;
filename=\"" + fileName);

           outputStream = response.getOutputStream();

               //outputLocalBuf = new
BufferedOutputStream(outputLocal);
               if (ftp.retrieveFileStream(fileName)==null)
                   throw new java.io.IOException(
                           "Get file from remote ftp host failed");
               else{

                inputStream = new BufferedInputStream(
                (ftp.retrieveFileStream(fileName)));

                int data;

                while((data = inputStream.read()) != -1) {
                 outputStream.write(data);
         }
               }
           } finally {
               if (inputStream != null) inputStream.close();
               if (outputStream != null) outputStream.close();

Thanks

Thomas Hawtin wrote:

Guan wrote:

Following ocde is used to download file from unix server, when i try on
window server, the downloading is fine. However when i download from
unix server in binary mode. The file is empty. Is there anything i
should take note of when trying to download file from unix

What do you mean binary mode? Non text/ content type?

response.setHeader("Content-Disposition","attachment;
filename=\"" + fileName);

My knee-jerk reaction is that if you don't know for sure the source of
fileName, could have something malicious in it (new lines, NUL
characters, double quotes, that sort of stuff). My second reaction is
that you only have a single double quote.

inputStream = new BufferedInputStream((fileName));

I take it this isn't your real code. It's difficult to diagnose problems
without seeing the actual code.

Tom Hawtin