Re: Calling Methods Again [so, are you guys sick of me yet?]

From:

RedGrittyBrick <RedGrittyBrick@SpamWeary.foo>

Newsgroups:

comp.lang.java.programmer

Date:

Wed, 02 Apr 2008 11:26:02 +0100

Message-ID:

<47f35f3d$0$10647$fa0fcedb@news.zen.co.uk>

KyoGaSuki wrote:

So! I finally think I understand writing a method! ...of course...I
still can't seem to figure out how to call it right, and therefore I
don't know if the method is right *if that made any sense*.

This is what I have so far *hides*:

/**
* @(#)try1.java
*
* try1 application
*
* @author
* @version 1.00 2008/4/1
*/
import java.util.*;
import javax.swing.*;
import java.io.*;
public class try1 {

    public static void main(String[] args)throws FileNotFoundException
{
     Scanner fileIn = new Scanner(new FileReader("Cylinders.txt"));
     PrintWriter fileOut = new PrintWriter("Output3.txt");
        System.fileOut.print("Please Enter The Radius: ");

1) "fileOut" is a local variable, it mustn't be prefixed by "System".

2) I can't understand why you are writing interactive prompts to a text
file.

         float radius = fileIn.nextFloat();
        System.fileOut.print("Please Enter The Height: ");
        float height = fileIn.nextFloat();
        System.fileOut.println("Height= " + height + ", Radius= " + radius +
", Base Area= " + area + ", Lateral Area= " + latArea + ", Surface
Area= " + surfArea + ", Volume= " + volume);

Mark has already pointed out that
", Base Area= " + area
should probably be
", Base Area= " + baseArea(radius)

    }

    public static float baseArea(float radius){
     float area;
     area = 3.14*radius*radius;
     return area;
    }

You could just write
     public static float baseArea(float radius){
       return 3.14f * radius * radius;
     }

Note 3.14f is a float, 3.14 is a double.

I suspect it would be better to use either
       return ((float)Math.PI) * r * r;
or
       return 3.1415927f * r * r;

depending on your desired precision.

<snip>

--
RGB