Re: how to close a stream in a try/catch block

From:

Michael Rauscher <michlmann@gmx.de>

Newsgroups:

comp.lang.java.programmer

Date:

Tue, 08 Aug 2006 08:53:01 +0200

Message-ID:

<eb9c9n$n55$01$1@news.t-online.com>

Hi,

jtl.zheng wrote:

I have written a method to compare two file:

[...]

I can't put the in1.close() into the finally block
the compiler say" variable in1 might not have been initialized"

Sure, you didn't initialize them :)

so I must write it three times before every return sentence
it's so bothering...do you have any better idea?

Close them in the finally block.

and it still have a problem
when it catch a exception,it will not reach the in1.close()
so when it bring on exception the stream can't be closed

public static boolean compareFile(File file1, File file2) {
     BufferedInputStream in1 = null;
     BufferedInputStream in2 = null;

     try {
       in1 = new BufferedInputStream(new FileInputStream(
           file1));
       in2 = new BufferedInputStream(new FileInputStream(
           file2));

       boolean result = true;
       int i;
       do {
           i = in1.read();
           result = (i == in2.read());
       } while ( result && i != -1 );

       return result;
     }
     catch (FileNotFoundException ex) {
       ex.printStackTrace();
     }
     catch (IOException ex) {
       ex.printStackTrace();
     }
     finally {
       close(in1);
       close(in2);
     }

     return false;
}

private static void close( InputStream is ) {
     if ( is != null ) {
         try {
             is.close();
         }
         catch ( IOException ioe ) {
             ioe.printStackTrace();
         }
     }
}

Bye
Michael