Re: Way to optimize this?

From:

Daniel Pitts <newsgroup.spamfilter@virtualinfinity.net>

Newsgroups:

comp.lang.java.programmer

Date:

Fri, 06 Nov 2009 12:51:57 -0800

Message-ID:

<O%%Im.4194$ET3.451@newsfe17.iad>

laredotornado wrote:

Hi,

I'm using Java 1.5. My code checker (PMD plug-in, part of Eclipse
Galileo), is complaining about the line "Integer fileCount = null;" in
the following ...

  public Integer getVendorRequestFileDigestCount(final
YouthfulDriverVendor vendor,
                                                 final String
requestFileDigest) {
    Integer fileCount = null;
    final Session session = sessionFactory.openSession();
    try {
      fileCount = (Integer)
        session. createCriteria(AddressRequestFile.class)
        .add(Restrictions.eq("requestFileDigest", requestFileDigest))
        .add(Restrictions.eq("vendor", vendor))
        .add(Restrictions.gt("processingResult", 0))
        .add(Restrictions.isNotNull("processingDate"))
        .setProjection(Projections.rowCount()).uniqueResult();
    } finally {
      session.close();
    }
    return fileCount;
  }

with the complaint, "Found 'DD' -- anomaly for 'fileCount', lines
123-126". Evidently, it doesn't like the fact that the value of the
variable "fileCount" changes. But I don't know how to rewrite this
code block to satisfy the code checker. Do you?

Thanks, - Dave

public Integer
   getVendorRequestFileDigestCount(final YouthfulDriverVendor vendor,
                                  final String requestFileDigest) {
     final Integer fileCount; // make final and don't assign yet.
     final Session session = sessionFactory.openSession();
     try {
       fileCount = (Integer)
         session.createCriteria(AddressRequestFile.class)
         .add(Restrictions.eq("requestFileDigest", requestFileDigest))
         .add(Restrictions.eq("vendor", vendor))
         .add(Restrictions.gt("processingResult", 0))
         .add(Restrictions.isNotNull("processingDate"))
         .setProjection(Projections.rowCount()).uniqueResult();
     } finally {
       session.close();
     }
     return fileCount;
   }

That is the easiest way. Note, you can simplify it even more:

public Integer
   getVendorRequestFileDigestCount(final YouthfulDriverVendor vendor,
                                  final String requestFileDigest) {
     final Session session = sessionFactory.openSession();
     try {
       return (Integer)
         session.createCriteria(AddressRequestFile.class)
         .add(Restrictions.eq("requestFileDigest", requestFileDigest))
         .add(Restrictions.eq("vendor", vendor))
         .add(Restrictions.gt("processingResult", 0))
         .add(Restrictions.isNotNull("processingDate"))
         .setProjection(Projections.rowCount()).uniqueResult();
     } finally {
       session.close();
     }
   }

no fileCoount variable worry about anywhere.