Re: Holy boop: goto for Java

On 04.06.2012 19:45, Lew wrote:


....

I'd rather

public void processResources(String ... resourceNames)
{
   for (String name : resourceNames)
   {
     try
     {
       final BufferedReader br =
         new BufferedReader(new FileReader(name));
       try
       {
         doSomething(br);
         reportComplete(name);
       }
       catch(IOException exc)
       {
         logger.error("Issue while processing "+ name, exc);
       }
       finally
       {
         close(br);
       }
     }
     catch(FileNotFoundException exc)
     {
       logger.error("Cannot find "+ name, exc);
     }
   }
}

close() is a static helper method which catches IOException and reports it.

In other words, I try to place the catch block at the end of a logical
section and use try catch to only execute some commands in absence of
error. The exception will make the continue superfluous. The advantage
in my eyes is that you can easily follow the regular flow and have error
handling concentrated in one place. I sometimes even refactor out
methods so I can have this catch at the end idiom.

In a more realistic example I'd probably extract parts of this into a
method (likely the inner try catch finally).

Kind regards

    robert

--
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/