Re: How would I rewrite this to satisfy the code checker?

From:

Tom Anderson <twic@urchin.earth.li>

Newsgroups:

comp.lang.java.programmer

Date:

Sat, 7 Nov 2009 12:57:31 +0000

Message-ID:

<alpine.DEB.1.10.0911071254340.17693@urchin.earth.li>

On Fri, 6 Nov 2009, Lew wrote:

Lew wrote:

There's nothing wrong with writing the 'readLine()' assignment twice,
since
that is what purchases the scope confinement for the 'line' variable.

Tom McGlynn wrote:

For me duplication of code is almost always inelegant and even
slightly dangerous. There's always the chance that there could be
unintended inconsistencies between the two instances--especially when
code gets modified. I make no claim that this is a massive issue, but
neither is the suggested change very large.

Copy-and-paste avoids divergence of the duplicated expressions.

Since I don't have a problem with the idiom the OP wrote about, I usually do
this:

for ( String line; (line = reader.readLine()) != null; )
{
...
}

This limits the scope of 'line', avoids curly-brace explosion and avoids
unnecessary duplication of code, much like your proposed 'while' syntax
except that it's legal.

I like that.

If you had this:

http://urchin.earth.li/~twic/Code/LineIterator.java

You could write:

import static LineIterator.lines;

for (String line: lines(reader)) {
...
}

However, you would throw away your ability to see exceptions, and there's
a bit more runtime overhead.

tom

--
Yesterday's research projects are today's utilities and tomorrow's
historical footnotes. -- Roy Smith