In article <1175121023.111583.251...@n59g2000hsh.googlegroups.com>,
Jason Cavett <jason.cav...@gmail.com> wrote:
I will be the first to admit I don't *really* understand threads.
Have a general idea, but, as I haven't had to use them too often, I
never really got a chance to learn them. Well...I'm working with them
now and that leads me to my question.
I am attempting to create an application that queues up files (given
by the user via the GUI) that will be processed. Whenever a file is
added to the queue, the processor takes the file off the queue and
processes it. The user should be able to continue working in the GUI
normally (as they would expect).
So far, I have three components to this aspect of my application.
They are:
ProjectModel - This is a user's project. It holds a list of the files
they're working on. This also provides the model that the GUI (View)
is created from. Anyway, what's important is that the ProjectModel
holds a "FileProcessor" object.
FileProcessor - The FileProcessor is simply a class that has a Vector
of Files. It provides (synchronized) methods to enqueue and dequeue
files. The FileProcessor has a FileWorkerThread object. The
FileWorkerThread is started in the FileProcessor's constructor.
FileWorkerThread - The FileWorkerThread object has a run() method
(implements Runnable) and does the work of processing the file.
FileWorkerThread also has a reference to the FileProcessor object (the
same exact object as above - it's passed in on the FileWorkerThread's
constructor).
Nitpick: Maybe it would be clearer to call this a FileWorker, so it's
clear that's not actually a type of thread, but just something to hold
the run() method.
The issue I am having, is I don't understand how wait and notify apply
in this case. I was initially attempting to use the FileProcessor
object as a lock. When the FileWorkerThread started up, if nothing
was in the queue of the FileProcessor, the FileWorkerThread was
supposed to wait until there was something in the queue.
Unfortunately, when I called wait() on the FileProcessor object (the
one that I was synchronizing over) the GUI would hang.
What I am attempting to have is something like this:
Open up a Project -> Queue a file in FileProcessor -> Notify the
FileWorkerThread that there are items waiting for it in the queue ->
FWT does the work -> When no more items are in the queue, FWT waits
until it receives another notify
My first thought would be use a blocking queue. More in another
post, since it seems that someone else has also replied suggesting
that.
Here is the code for the FileProcessor and the FileWorkerThread:
---
public class FileProcessor {
private Vector<File> files;
private FileWorkerThread worker;
public FileProcessor() {
files = new Vector<File>();
// worker thread setup
worker = new FileWorkerThread(this);
Thread workerThread = new Thread(worker, "Worker Thread");
workerThread.run();
}
Probable "gotcha": I think you mean start() rather than run() --
run() executes the right code, but in the wrong thread --
in the thread calling the FileProcessor constructor rather
than in the thread you just created.
public synchronized void enqueueFile(File file) {
files.add(file);
}
public synchronized File dequeueFile() {
File file = null;
if (files.size() != 0) {
file = files.firstElement();
files.remove(file);
}
return file;
}
public synchronized void removeFile(File file) {
files.remove(file);
}
public synchronized void removeFile(int position) {
files.remove(position);
}
public synchronized void notifyWorker() {
this.notify();
}
public synchronized void waiting() {
try {
this.wait();
this.notify();
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
---
public class FileWorkerThread implements Runnable {
private FileProcessor processor;
public FileWorkerThread(FileProcessor processor) {
this.processor = processor;
}
/**
* @see java.lang.Runnable#run()
*/
public void run() {
// work forever
while (true) {
// check for work
File file = processor.dequeueFile();
if (file == null) {
synchronized(processor) {
processor.waiting();
}
} else {
// do stuff here
}
}
}
}
Thanks
P.S. At some point, I'm going to want to use the worker thread to
update a progress bar - I don't know if that'll affect anything or if
there's anything additional I will need to think about.
--
B. L. Massingill
ObDisclaimer: I don't speak for my employers; they return the favor.- Hide quoted text -
- Show quoted text -- Hide quoted text -
- Show quoted text -- Hide quoted text -
- Show quoted text -
Probable "gotcha": I think you mean start() rather than run() --
run() executes the right code, but in the wrong thread --
in the thread calling the FileProcessor constructor rather
than in the thread you just created.
Whoops. My mistake. I saw that after I posted to the code here.