Re: A little afternoon WTF
On Thu, 13 May 2010, Roedy Green wrote:
On Thu, 13 May 2010 18:12:28 +0100, Tom Anderson
<twic@urchin.earth.li> wrote, quoted or indirectly quoted someone who
said :
private static String header = "" +
"<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n" +
motive? Contractor may have known precisely what he needed the first
line to look like, but could not bludgeon his XML package to produce it
so gave up and did it manually.
What XML package? I'm not sure what you mean.
The "" + idiom is sometimes used to force an int to string. Perhaps he
cloned code from such an example.
Possible, although it seems a bit of a stretch. There are string constants
all over that bit of the codebase, and i can't think of a single instance
of the ""+int trick in the entire system. I think it's pretty bad
practice, so i'd remember if i'd seen it. It's quite possible he learned
the idiom from that use, though.
Using a StringBuilder with precise size estimate I discovered speeded my
static macro code up by 10%. I suspect then that any sort of framework
would similarly benefit. However, he did not specify an estimate, thus
defeating the point of manual StringBuilders.
Indeed. And using that approach to initialise static constants whose
values would otherwise be compile-time constants, and so could be stored
complete in the constant pool, would be foolish anyway.
tom
--
everything is temporary