Re: Change decimal color code on the fly

From:

Eric Sosman <esosman@comcast-dot-net.invalid>

Newsgroups:

comp.lang.java.help

Date:

Fri, 16 Nov 2012 13:56:37 -0500

Message-ID:

<k86295$igh$1@dont-email.me>

On 11/16/2012 1:39 PM, Bob wrote:

[...]
Thanks for your help. This sequence
is what was needed.
.....
  mSet = redStr + greenStr + blueStr;
       mSetx= "121000000";
       if (mSet.equals( mSetx)) {
          mSet = "";

What's this for? It's harmless, but it's useless because you
never use the assigned value for anything: You wipe it out in the
very next line. You have written yourself a note, then immediately
erased and overwritten it.

... all of which makes me wonder whether there's something
you want accomplished, something you imagine this assignment
will accomplish for you. If so, I've got bad news ...

          mSet = Integer.toString (255255255);
          System.out.println("revision "+ mSet);
       }
       colorpxl.add(mSet);
       mSet = "";

Can't tell whether this assignment is or isn't worthwhile.
If the value of `mSet' will be used again, maybe the assignment
is needed -- but then again, maybe it's just a repetition of the
same ineffectual pattern as the first one. I still harbor a
suspicion that you're missing something.

--
Eric Sosman
esosman@comcast-dot-net.invalid