Re: equals(), Sets, Maps, and degrees of equality
On 11/10/2011 10:29 AM, Sean Mitchell wrote:
On Nov 10, 10:21 am, markspace<-@.> wrote:
Possible, but I could see a lot of concurrency issue arising. Might
work well in a single threaded application.
What? Why? There's no concurrency issues there. There's no state
beyond what is in the Dog object. Method call != concurrency issue. In
fact it's the opposite, method calls are inherently thread safe.
If you need concurrency, you add it to the Dog object.
Maybe I don't understand what you are proposing. It sounds like you
want a singleton wrapper, into which I stuff my Dog, before I put him
into my Set/Map.
I think "concurrency issues" might not be the best description,
but there are certainly drawbacks to markspace's suggestion. Back
to your original post: You wanted a Dog whose breed (only) would
govern its membership in a Set<Dog> but whose name (only) would
matter for a Map<Dog,Owner>. markspace's idea of endowing each Dog
with a DogComparisonStrategy wouldn't work if the same Dog instance
could be a member of the Set *and* a key in the Map: You'd need to
visit every Dog and reset its DogComparisonStrategy before doing
any operation on either the Set or the Map. (Strictly speaking,
you'd only need to visit the Dogs that participated in the relevant
data structure -- but since it would be at best dubious to traverse
a Set or Map whose Dogs were in the wrong state you'd need a third
Collection<Dog> that would not use the DogComparisonStrategy at all.)
The notion of making Breed and Name inner classes of Dog seems
more and more attractive:
class Dog {
class Breed { ... };
class Name { ... };
private Breed breed;
private Name name;
...
}
The wrapper approach could also work, and would be necessary if Dog
weren't alterable:
class Dog {
private String name;
private String breed;
...
}
class DogByBreed {
private Dog dog;
...
public int hashCode() {
return dog.getBreed().hashCode();
}
...
}
class DogByName {
private Dog dog;
...
public int hashCode() {
return dog.getName().hashCode();
}
...
}
--
Eric Sosman
esosman@ieee-dot-org.invalid