Re: Holy boop: goto for Java

From:

Lew <lewbloch@gmail.com>

Newsgroups:

comp.lang.java.programmer

Date:

Mon, 4 Jun 2012 14:52:00 -0700 (PDT)

Message-ID:

<a14fe249-5b44-42fb-ac24-09a51daf9aeb@googlegroups.com>

Daniel Pitts wrote:

Lew wrote:

public void processResources(String ... resourceNames)
{
   for (String name : resourceNames)
   {
     BufferedReader br;
     try
     {
       br = new BufferedReader(new FileReader(name));

FWIW, this is a potential resource leak (think OOM on the "new
BufferedReader")

OOM is not a resource leak, it's a program crash.

I generally don't handle 'Error's. (Except when I do.)
If the OOM happens here as you suggest, well, what Leif said.

     }
     catch(FileNotFoundException exc)
     {
       logger.error("Cannot find "+ name, exc);
       continue;
     }
     assert br != null; // and is valid

br is never assigned null, you could make br final. I think it *should*
be final.

Yes. Actually, in real code with this idiom I do make it final. Good catch.

     try
     {
       doSomething(br);
     }
     finally
     {
       try
       {
         br.close();
       }
       catch(IOException exc)
       {
         logger.error("Cannot close "+ name, exc);
         continue;
       }
     }
     reportComplete(name);
   }
}

(Not using try-with-resources here, in order to illustrate the idiom.)

Hmm, a failure to close causes a resource processing not to be complete?

You read too much into the method names.

It's a pattern. I do not claim the names and all are useful in real life, only for pedagogy.

Use better names if these make you twitch.

--
Lew