Re: Discrepancy in current hour
Rhino wrote:
I am happy to learn more about Java and improve my code but getting
told to do it one way, spending time to do it, then being told to
change it all back to the way it was is frustrating to say the least.
No one told you to "change it all back to the way it was". You presented a
whole bunch of complicated code at one point that was dragging out integers
from Calendar fields and padding them with characters into Strings. All that
messy conversion seemed better suited to use of DateFormat. As a separate
question, I asked why you were wrapping a simple call to
Calendar.get(Calendar.HOUR), a small piece of the overall stringification
process only. Separate issue, and a question, not advice.
I'm just trying to be obliging here and accept what I'm being told
rather than make everyone justify their advice. I'm assuming you guys
know more than me. Maybe I have to start getting a little more
assertive and make you justify the changes you are asking me to
make....
How about distinguishing between advice ("Try X") and a request for
information ("Why Y?"). The latter assumes you have a reason for doing
something that the questioner has interest in knowing.
An example of advice:
Eric Sosman wrote:
Suggestions:
...
4) Learn to use the format() methods of PrintStream and/or
of String.
Lew wrote:
Or use java.text.DateFormat / SimpleDateFormat.
<http://java.sun.com/javase/6/docs/api/java/text/DateFormat.html>
<http://java.sun.com/javase/6/docs/api/java/text/SimpleDateFormat.html>
Those related to providing String representations.
An example of a request for information:
I wonder why you write a utility method to get the current hour
when the standard API already provides a one-line way to do so.
Advice there would have been redundant since you were already using the
technique in the body of your utility method, so clearly you knew of it. It
was just one programmer looking to find out what another programmer's
reasoning was.
"Get the current hour" is a different task from "provide a String
representation of a Calendar instance". Advice appropriate to one task might
not apply to the other.
--
Lew