Re: Downloading a file in Linux
Grzesiek wrote:
Hi,
I use the following function to download a jar file from my website:
public synchronized boolean copyFileFromWeb(){
try
{
URL url = new URL(sourceURL);
URLConnection urlC = url.openConnection();
InputStream is = url.openStream();
System.out.print("Copying resource (type: " +
urlC.getContentType());
Date date=new Date(urlC.getLastModified());
System.out.flush();
FileOutputStream fos=null;
fos = new FileOutputStream(destinationPath);
Why assign to null and then assign a proper value the statement after?
int oneChar, count=0;
while ((oneChar=is.read()) != -1)
{
Copying one character is liable to be relatively slow. At least copy
through a byte array.
fos.write(oneChar);
count++;
}
is.close();
fos.close();
These should each be in a finally block of a try-finally.
System.out.println(count + " byte(s) copied");
return true;
}
catch (Exception e){
System.err.println(e.toString());
}
It's not a great idea to catch Exception rather than the actual
exception type you wish to catch.
return false;
}
In Windows XP it works perfectly, but in Linux it works very slow and
the downloaded file is corrupted! What is wrong?
When you say slowly, is it the first byte which is slow or each
subsequent byte. If it is only up to the first byte, then on obvious
suspect is DNS misconfiguration (which happens more often on Windows).
When you say the file is corrupt, what do you actually get? Truncated?
Complete rubbish? Some bytes wrong? Something else?
You might want to try nc to see what the web server is actually doing.
Tom Hawtin