Re: Socket is still connected after Server-Side socket termination.

From:

Lew <lew@lewscanon.com>

Newsgroups:

comp.lang.java.programmer

Date:

Wed, 19 Sep 2007 18:14:22 -0400

Message-ID:

<dvydncY-ga2iAmzbnZ2dnUVZ_uevnZ2d@comcast.com>

pek wrote:

To make things easier here is the code of the method run of the
looping thread :

StringBuffer outgoingBuffer;

StringBuilder is the preferred class these days.

List<Message> incomming;

Consider spelling the variable the same as the highly similar natural-language
word to avoid later maintenance errors.

while (running) {
  try {

    int messageCount = outgoing.size();
    outgoingBuffer = new StringBuffer();
    for (int i=0;i<messageCount;i++) {
      outgoingBuffer.append( new
String(parser.serialize(outgoing.poll())));
    }
    out.write(outgoingBuffer.toString().getBytes());

    int availableBytes = in.available();
    byte[] toDeserialize = new byte[availableBytes];

You don't really need to allocate a new buffer each time. You can re-use a
single buffer.

in.read(toDeserialize);

Others have told you of the value of checking the return value of read() to
make sure that you have received any data at all, and if so, all that you expect.

You should do that. If it returns -1, the socket is closed.

incomming = parser.deserialize( toDeserialize );

But you have no certainty that the toDeserialize has everything you want in
it, or anything at all!

You need to check the return value of read().

--
Lew