Re: BUG in MFC vc2008!

From:

"Doug Harrison [MVP]" <dsh@mvps.org>

Newsgroups:

microsoft.public.vc.mfc

Date:

Sun, 06 Jul 2008 11:28:46 -0500

Message-ID:

<1mr174pu8pu32g9u8np2n6jj8kn73v6rsg@4ax.com>

On Sun, 6 Jul 2008 12:13:05 +0300, "Daniel Cohen Gindi"
<danielgindi@gmail.com> wrote:

Hello Microsoft's guys! :-)

I have detected a bug in MFC, with vc2008!

Take a look at afxstate.cpp:
Line 185-190:
m_pDllIsolationWrappers = new
CDllIsolationWrapperBase*[_AFX_ISOLATION_WRAPPER_ARRAY_SIZE];
#ifndef _AFX_NO_AFXCMN_SUPPORT
m_pDllIsolationWrappers[_AFX_COMCTL32_ISOLATION_WRAPPER_INDEX] = new
CComCtlWrapper;
#endif
m_pDllIsolationWrappers[_AFX_COMMDLG_ISOLATION_WRAPPER_INDEX] = new
CCommDlgWrapper;
m_pDllIsolationWrappers[_AFX_SHELL_ISOLATION_WRAPPER_INDEX] = new
CShellWrapper;
Then line 335-339:

#ifndef _AFX_NO_AFXCMN_SUPPORT
delete m_pDllIsolationWrappers[_AFX_COMCTL32_ISOLATION_WRAPPER_INDEX];
#endif
delete m_pDllIsolationWrappers[_AFX_COMMDLG_ISOLATION_WRAPPER_INDEX];
delete [] m_pDllIsolationWrappers;

Now see - the wrapper for SHELL32.DLL is not freed!

Only two of three wrappers are freed, then the array is freed.

I have used Visual Leak Detector, to find if any leaks are present in my
server program , and I found one, which was a CString allocation, and it was
originated in the CShellWrapper::CShellWrapper, which is called in line 190
of afxstate.cpp.

Should I recompile mfc myself? or any fix is pending...

File a bug on Connect as suggested, but don't even think about recompiling
MFC unless this is a leak that grows over time. If it occurs only when a
program exits, it isn't really a leak, as the OS will reclaim the memory
anyway. If it occurs when a DLL is dynamically unloaded, it's a problem
only if the DLL is frequently loaded and unloaded.

--
Doug Harrison
Visual C++ MVP