Re: Pass CString to printf?

From:

"Jonathan Wood" <jwood@softcircuits.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Thu, 25 Sep 2008 18:15:18 -0600

Message-ID:

<Op2pL02HJHA.4416@TK2MSFTNGP06.phx.gbl>

Doh! You're right. The format string must be the right type, but any
additional arguments are untyped.

'scuse me.

--
Jonathan Wood
SoftCircuits Programming
http://www.softcircuits.com

"Mark Salsbery [MVP]" <MarkSalsbery[MVP]@newsgroup.nospam> wrote in message
news:ulD3Ey1HJHA.4084@TK2MSFTNGP04.phx.gbl...

"Jonathan Wood" <jwood@softcircuits.com> wrote in message
news:eXWDyj1HJHA.2580@TK2MSFTNGP05.phx.gbl...

A cast to LPCTSTR in an argument to printf() in a Unicode build, should
cause a warning/error. In a Unicode build, LPCTSTR is LPCWSTR and
printf() expects LPCSTR.

That's what I originally thought, but with var args the compiler doesn't
give a warning even at level 4.

Here's my test code for this thread:

//
// Tested on Visual Studio 2008 SP1
//
CString kindOfFruit = _T("bananas");
int howmany = 25;
char buff[80];
sprintf(buff, "You have %d %s", howmany, CT2A(kindOfFruit) );
sprintf(buff, "You have %d %s", howmany, (LPCTSTR)kindOfFruit );
sprintf(buff, "You have %d %s", howmany,
static_cast<LPCTSTR>(kindOfFruit));

No warnings (except the deprecated functions).

Mark

--
Mark Salsbery
Microsoft MVP - Visual C++