Re: CEdit control crashes when resized... Problem solved??
Helo again,
I've founs a way to avoid the crash.
I do not fully understand why it works now, but I'm happy with this solution
for now and I.m able to continue my work.
Workaround (BusyResizing is true during processing of the WM_SIZE message):
--------------------------------------
LRESULT CdaVinciAuxDlg::DefWindowProc( UINT message, WPARAM wParam, LPARAM
lParam )
{
if( message == WM_CTLCOLOREDIT )
{
if( !BusyResizing && !BusyColoring )
{
BusyColoring = true;
if( SetControlColor( (HDC)wParam, (HWND)lParam, ctl_id ) )
{
BusyColoring = false;
return( (LRESULT)CtrlBrush );
}
}
BusyColoring = false;
}
}
}
--------------------------------------
I suspect there were too many calls to the coloring function during resizing.
I hope this workaround will be stable, but you never knw... ;)
By the way, this application does not know the colors when it starts,
therefore they must be set at run time.
Thank you every body!
ElCarso
"David Ching" wrote:
"ElCarso" <elcarso@somewhere.com> wrote in message
news:06C7FB48-1D30-4D5B-98ED-CB38F05CE13E@microsoft.com...
Thanks everybody.
I've found the source of the problem (but not a solution nor a workaround
for it yet). It resides in a portion of code that I did not show before.
Se
below:
------------------------------------
HBRUSH CtrlBrush;
bool CdaVinciAuxDlg::SetControlColor( HDC hdc, HWND hwnd, UINT nCtlColor )
{
int ctrl_id = ::GetDlgCtrlID( hwnd );
if( ctrl_id == IDC_EDIT_WINDOW )
{
SetBkColor( hdc, DataHandler.WinBgColor ); //
Change the CONTROL background color
SetTextColor( hdc, DataHandler.WinTextColor ); //
Change the TEXT color
CtrlBrush = (HBRUSH)CreateSolidBrush( DataHandler.WinBgColor ); //
Change the TEXT background color
return( true );
}
return( false );
}
LRESULT CdaVinciAuxDlg::DefWindowProc( UINT message, WPARAM wParam, LPARAM
lParam )
{
if( message == WM_CTLCOLOREDIT )
{
if( SetControlColor( (HDC)wParam, (HWND)lParam ) ) return(
(LRESULT)CtrlBrush );
}
return( CDialog::DefWindowProc( message, wParam, lParam ) );
}
------------------------------------
If I disable the handling above, the edit control does not crash.
What is wrong with my code?
It seems that I'm wasting resources in some way.
Possibly HDC problems?
Please help.
Thank you all.
ElCarso
Call CreateSolidBrush() once and return that HBRUSH continually, not create
it each time in SetControlColor(). Don't make CtrlBrush a global
varialbe; return it from SetControlColor().
MFC style is not overriding DefWindowProc(), you should instead create a
handler OnCtlColor(), for WM_CTLCOLOR using the Properties window. when
CdaVinciAuxDlg is edited.
But none of this causes a "crash". I would rewrite your app as Joe
suggests, since that will save time in the long run. It is harder to
decipher programming problems which cause stop ship bugs vs. those that are
just unoptimal and prone to cause problems in the future.
-- David