Re: Constructor of dialog box...

From:

"Doug Harrison [MVP]" <dsh@mvps.org>

Newsgroups:

microsoft.public.vc.mfc

Date:

Wed, 01 Oct 2008 12:22:09 -0500

Message-ID:

<j5c7e4pl2svfk953f60vei3mufpo8lh8me@4ax.com>

On Wed, 1 Oct 2008 06:52:46 -0700 (PDT), RAB <rabmissouri@yahoo.com> wrote:

I have an MFC VC++6 project. In a dialog box I want to pass a CString
variable when I call the dialog class. And I want the CString variable
to populate a static text box.

For example:

void MyParentDlg::OnButton()
{

    MyDialog aa(NULL, "hello");
    aa.DoModal();

}

//Start of MyDialog class code

CString hold;

MyDialog::MyDialog(CWnd* pParent /*=NULL*/, CString PassString)
    : CDialog(MyDialog::IDD, pParent)
{
        hold = PassString;
}

BOOL MyDialog::OnInitDialog()
{
    CDialog::OnInitDialog();

    m_MyStaticTextBox.SetWindowText(hold);

    return TRUE; }

Is this the best way to set up this situation?

The constructor aspect is, but there are a couple of things you should do
differently:

1. Make the pParent parameter the last one. This will allow you to retain
its default value.

2. Make the PassString parameter const CString&.

3. Initialize "hold" in the member initialization list.

4. If the ctor has two parameters with the latter of them having a default
argument, declare the ctor "explicit".

As for initializing m_MyStaticTextBox, normally you would do this with DDX.

--
Doug Harrison
Visual C++ MVP