Re: CListBox issue
On Tue, 17 Mar 2009 18:25:18 -0400, "CodeTestDummy"
<sharp_mindTAKEOUT@email.TAKEOUT.msn.com> wrote:
All,
I am having a problem with CListBox. When ever I try to use AddString my
program close. Does anyone have any ideas? Thanks in advance...
void CGrpMemPropertyPage::GetMembers(TCHAR *szRemoteServer, TCHAR
*szGroupName)
{
NET_API_STATUS info;
LOCALGROUP_INFO_1 *loc= NULL, *locTemp= NULL;
TCHAR szComment[256], szGrpName[256];
TCHAR szServerName[256];
CString csGrpName;
dwEntries = 0, dwTotal = 0, dwResumeHandle = 0;
info = NetLocalGroupGetMembers((LPWSTR)szRemoteServer, (LPWSTR)szGroupName,
1, (LPBYTE*)&loc,
MAX_PREFERRED_LENGTH, &dwEntries, &dwTotal, &dwResumeHandle);
locTemp = loc;
for(int i = 0; i < dwEntries; i++)
{
c_ListMember.AddString(locTemp->lgrpi1_name);
locTemp++;
}
NetApiBufferFree(loc);
}
The obvious guess is that loc == NULL after the call to
NetLocalGroupGetMembers. You need to check the return code and probably
handle the ERROR_MORE_DATA case as well. Or, there could be something wrong
with c_ListMember. For example, it won't work if you try to perform the
above before OnInitDialog has been called, or after DoModal has returned,
because at those times, there is no HWND bound to c_ListMember. You haven't
described the problem in sufficient detail to be more specific. Have you
tried running it under the debugger? I expect the debugger would make it
pretty easy to determine the cause of this problem.
Some other notes...
It makes no sense to use TCHAR arrays when WCHAR arrays are required. If
you were to compile for ANSI, your program would compile correctly due to
the casting you do but malfunction since an array of ANSI characters is not
interchangeable with an array of WCHAR.
Doing multiple things on one line is considered bad style by most people:
LOCALGROUP_INFO_1 *loc= NULL, *locTemp= NULL;
TCHAR szComment[256], szGrpName[256];
dwEntries = 0, dwTotal = 0, dwResumeHandle = 0;
It's easier to read and maintain like this:
LOCALGROUP_INFO_1* loc = NULL;
LOCALGROUP_INFO_1* locTemp = NULL;
TCHAR szComment[256];
TCHAR szGrpName[256];
dwEntries = 0;
dwTotal = 0;
dwResumeHandle = 0;
Doing it this way, you even get to pretend the * modifies the type instead
of the variable, which is something Stroustrup popularized way back when.
--
Doug Harrison
Visual C++ MVP