Re: Fixing new for VC6- on project-local basis

ultranet wrote:


In this case my recommendation would be to use malloc and free:

void *__cdecl operator new(size_t size)
{
     void *p = malloc(size);
     if ( p == NULL) {
        // TODO: log it
        throw bad_alloc();
     }
     return p;
}

void *__cdecl operator new(size_t size, const std::nothrow_t&)
{
     void *p;
     try
     {
         p = malloc(size);
     }
     catch (std::bad_alloc &)
     {
         p = NULL;
        // TODO: log it
     }
     return p;
}

void __cdecl operator delete(void *p)
{
     free(p);
}

Hope this helps your recursion problem.

One more thing. You were trying to catch the std::bad_alloc by value.
I'm not so sure it's a good idea. Generally speaking, catching
exceptions by value can lead to type truncation and unnecessary copying
of the exception object. That being said, I'd catch it by reference, so
I modified that line accordingly:

catch (std::bad_alloc &)

Finally, I've removed the exception specifiers, mainly because most C++
experts advice against it. It's up to you, but IMHO it gives a false
sense of security with quite a bit of a performance penalty. I'm not
familiar how Microsoft handles throw(), but the standard behavior is
pretty awful.

Tom