RE: Strange crash reported from winQual. Is it caused by _endthreadex

From:

=?Utf-8?B?QnJ1bm8gdmFuIERvb3JlbiBbTVZQIFZDKytd?= <bruno_nos_pam_van_dooren@hotmail.com>

Newsgroups:

microsoft.public.vc.language

Date:

Wed, 18 Apr 2007 00:56:01 -0700

Message-ID:

<DA06F4D3-43E1-42A3-BE1F-BA69C8AA0809@microsoft.com>

wrote:

I have a thread that I launch as follows in C++:

BOOL CMyThread::CreateThread()
{
  unsigned threadid;
  m_hThread = (HANDLE) _beginthreadex(NULL, 0, CMyThread::BeginThread, this,
0, &threadid);
  return (m_hThread != (HANDLE) -1);
}

static unsigned __stdcall CMyThread::BeginThread(void *parg)
{
  ((CMyThread *) parg)->InitInstance();
  int ret_val = ((CMyThread *) parg)->ExitInstance();
  _endthreadex(ret_val);
  return ret_val;
}

{
....
CMyThread *pNewThread = new CMyThread();
pNewThread->CreateThread();
....
}

I'm calling _endthreadex because it suggests I should in some samples.
However, I'm starting to wonder if it's necessary or desirable.

Hi,

From MSDN
"however, _endthread or _endthreadex is called automatically when the thread
returns from the routine passed as a parameter."
You can call _endthreadex is redundant.
Try removing it. You are not calling it twice by accident, are you?

Btw: also from MSDN:
"Like the Win32 ExitThread API, _endthreadex does not close the thread
handle. Therefore, when you use _beginthreadex and _endthreadex, you must
close the thread handle by calling the Win32 CloseHandle API.
Note
_endthread and _endthreadex cause C++ destructors pending in the thread not
to be called."

Could you show us the rest of your thread class?

Apart from the thread class itself, there is a chance that there is a
problem in whatever function your thread class is executing.

--
Kind regards,
    Bruno.
    bruno_nos_pam_van_dooren@hotmail.com
    Remove only "_nos_pam"