Yes, I agree. That is one of the best reason to use a const or #define for
these kinds strings. At least if the file is named wrong it's named the
same in both places where it is used. CString works as well of course, but
"Joseph M. Newcomer" <newcomer@flounder.com> wrote in message
See below...
On Wed, 9 Jul 2008 13:52:00 -0700, Phil <phil78@sbcglobal.net> wrote:
I have a section of code that needs to output to a text file using
CStdioFile
and then immediately display it using notepad.
I have tried the following, but it doesn't find the file. However, if I
go
to window explorer, the file is there. Any Ideas?
CStdioFile af;
****
CString pathname = WORKDIR + _T("steerptr.txt");
Note that I didn't see the mis-spelling either, but it wouldn't have
affected me because I
would not have tried to use the same string twice. I would either have
done a #define of
the name or I would have stored it in a variable as above, so there would
be no
possibility of the error you got.
****
if
(af.Open(theApp.WORKDIR+"steerprt.txt",CFile::modeCreate|CFile::modeWrite))
****
How many things are already wrong with this?
It uses theApp for some variable. This is wrong. You should not be
tossing values into
your CWinApp-derived class as if they are global variables. If this code
is in the
CWinApp class, it does not need to use theApp; if it is not in the CWinApp
class, it does
not need to know about it.
The creation of the path in two places looks suspicious, and this was
before I saw the
other comments pointing out the typo.
Do not use "xxx" for literal strings; use _T("xxx") so you are
Unicode-aware
Use spaces around binary operators and after commas so the code is
readable.
if(af.Open(pathname, CFile::modeCreate | CFile::modeWrite))
Why is it that so many programmers do not believe in readability, but
think that the
fewest number of characters typed is the quality measure for code? If you
believe this,
don't code in C, code in APL.
****
{
af.WriteString(tstr);
af.Flush();
****
There is no need to do a flush; this will happen automatically with the
close
****
af.Close();
}
HWND mainhwnd = GetSafeHwnd();
****
Why do you need a variable here?
****
ret1 = (int)
ShellExecute(mainhwnd,"open",theApp.WORKDIR+"steerptr.txt","",theApp.WORKDIR,SW_SHOWNORMAL);
****
ShellExecute(GetSafeHwnd(), _T("open"), pathname, _T(""), WORKDIR,
SW_SHOWNORMAL);
****
ShellExecute returns 2 (File not found)
Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm