Re: Optimization of code
When I compile the code you gave me to search for string I get 3 errors, see
below
LPSTR p = (LPSTR)buffer.GetData();
LPSTR comparand = "Prieview";
while(true)
{ /* scan file */
LPSTR found = strstr(p, comparand);
if(found)
{ /* found it */
p = found + comparand.GetLength(); //error C2228: left of
'.GetLength' must have class/struct/union type
break;
}
else{
p = found + strlen(found) + 1;
if(p >= &buffer[buffer.GetSize()]) // error C2446: '>=' : no
conversion from 'unsigned char *' to 'char *'
//error C2230:
'>=' : indirection to different types
break; // all done
}
}
Am I missing something obvious??
"Joseph M. Newcomer" <newcomer@flounder.com> wrote in message
news:jmlt95937som3hk6so4uvkn3uuk9kgamlb@4ax.com...
Gee, that should be trivially obvious that it could have been written
LPSTR pattern = "Pattern";
Note that none of the code that follows cares if it is an LPSTR or a
CStringA.
joe
On Wed, 2 Sep 2009 15:07:26 -0400, "Eddards" <eddards@verizon.net> wrote:
Joe,
I beg to differ that you didn't use CStringA
Here is the code you gave me.....
Look at the 3rd line!
Here's a very simple algorithm:
int i = 0;
LPSTR p = (LPSTR)buffer.GetData(); // ASSUMES 8-BIT CHARACTERS
CStringA comparand = "Pattern"; // or whatever your pattern is!
while(true)
{ /* scan file */
LPSTR found = strstr(p, comparand);
if(found)
{ /* found it */
....do something
p = found + comparand.GetLength();
} /* found it */
else
p = found + strlen(found) + 1;
if(p >= &buffer[buffer.GetSize()]
break; // all done
} /* scan file */
This, as written, will find every occurence of the string so if the
data
is
<random hex data>PatternPatternPattern<random hex data>Pattern<random
hex
data><EOF>
it will find the pattern four times.
=======================================================================================
"Joseph M. Newcomer" <newcomer@flounder.com> wrote in message
news:9ldt95drg375dauccem9re52edi7ffpbq9@4ax.com...
Why do you think 5000 lines poses any problem? You can certainly move
the
functions
around, but it is a real pain to use the tools, more of a pain to edit
the
files. I gave
up on this long ago. File length is not a critical metric of anything.
More below...
joe
On Wed, 2 Sep 2009 10:15:11 -0400, "Eddards" <eddards@verizon.net>
wrote:
Is it possible to have the "void CMyAppDlg::OnSelchangeFilelist() " run
in
a
separate cpp file?
I mean, instead of adding more and more large functions within the main
Dlg?
I have seen some apps where the main Dlg file is quite long over
5000lines.
Wouldnt it be better to break the functions into separate files then?
Also, in the code below, what is the best way to search for a text
string
which is placed within this file which has many 0x00(null) within?
I am using VC6 so CStringA doesnt work as it has been suggested.
Should I just read byte by byte till I find the first char then the next
char till I find the string?
void CMyAppDlg::OnSelchangeFilelist()
{
CString selected;
TCHAR Select[500];
int nSelect;
nSelect = c_List.GetCurSel();
DlgDirSelect(Select, IDC_FILELIST);
c_List.GetText(nSelect, Select);
c_FileSelected.SetWindowText(Select);
selected = Select;
Fname = DEFAULT_PATH + selected;
CFile f;
if(!f.Open(Fname, CFile::modeRead)){
AfxMessageBox("Open failed");
return;
}
ULONGLONG len = f.GetLength();
CByteArray buffer;
buffer.SetSize(int(len) + sizeof(TCHAR));
if(!f.Read(buffer.GetData(), (UINT)len))
{
f.Close();
AfxMessageBox("Read failed");
return;
}
buffer[int(len)] = 0;
if(sizeof(TCHAR) > 1)
buffer[int(len) + 1] = 0;
f.Close();
****
I already gave you the code to do this. I even wrote it in terms of
strstr. Since you
took al lthe other code, why didn't you take that code as well (it
doesn't
use CStringA!)
joe
****
// additional decode of file here
}
Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm
Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm