Re: Having Problems getting things consistently out of the registry in Windows 98

Joe and all,

Sorry its a little long;

I did set the breakpoint in Windows XP on RegQueryValueEx and
everything looked ok for the parameters, even the return value was 0
(SUCCESS). So I went and looked at the return value in Windows 98, by
using a Messagebox, I noticed a 87 was being returned. I believe,
please correct me if I am wrong, I am unable to debug this application
actively in Windows 98 as I am using Visual Studio 2003 and the MSLU.

Does Visual Studio 2003 even install on a Win98 Box?
Is there a Debug version of the MSLU out there?

In either case I dug a little deeper and noticed the dwType was not
really necessary as I am sure this function should always return a
string. There are two functions that have been created one for getting
a String and the other for getting a Integer. I set the value as NULL
for the dwtype and it seems to work ok now. I was puzzled by this and
looked deeper and noticed in Windows XP that the value for this once
created was a value other then 0. I am unsure if this was the cause or
not in the Windows 98 machine.

In either case it still does not explain why the following original
code does not consistently work;

#define REGISTRY_SECTION _T("User Profile")
#define REGISTRY_USER_ID _T("User ID")
#define REGISTRY_MSMCODE _T("MSMCode")

CWinApp* pApp = AfxGetApp();
CString nValue4;
nValue4 =
pApp->GetProfileString(REGISTRY_SECTION,REGISTRY_MSMCODE,_T("NO VALUE
RETURNED")); //get the value from the registry

CString strValue;
strValue = pApp->GetProfileString(REGISTRY_SECTION,
REGISTRY_USER_ID,_T("NO VALUE RETURNED"));

The above code will bring values back the first time but not the second
time forward though. The code is in a command to run a dialog so I can
execute the same code countless times easily. This is getting a user
name and an alphabetic id code to display in the dialog. The values I
get are "NO VALUE RETURNED" on the next X number of times after the
first. I am unsure why its having problems, the values going into the
function are PreProcessor Directives and the last is a constant hard
coded string. I have even tried removing the ,_T("NO VALUE RETURNED")
and placed in a NULL and there is no change in behavior just the
returned string is empty in the case of the NULL.

Whats interesting is if I use the following;

CString nValue4;
nValue4 =
theApp.GetProfileString(REGISTRY_SECTION,REGISTRY_MSMCODE,_T("NO VALUE
RETURNED")); //get the value from the registry

CString strValue;
strValue = theApp.GetProfileString(REGISTRY_SECTION,
REGISTRY_USER_ID,_T("NO VALUE RETURNED"));

It seems to works fine no matter how many times I try it.

Also I have even tried my own functions, after I figured out the issue
we discussed earlier;

CString nValue4;
nValue4 = GetRegistryString(REGISTRY_MSMCODE);

CString strValue;
strValue = GetRegistryString(REGISTRY_USER_ID);

The function GetRegistryString is as follows;

CString CAApp::GetRegistryString(CString strKeyName)
{
    LONG lRet;
    wchar_t szData[1024];
    ZeroMemory(szData,2048);

     DWORD dwBufLen=1024;

     HKEY hKey;

    lRet = RegOpenKeyEx(HKEY_CURRENT_USER,
_T("Software\\GFS\\TheData\\User Profile\\"), 0,KEY_QUERY_VALUE,
&hKey);

    if(lRet != ERROR_SUCCESS)
    {
        RegCloseKey(hKey);

         return _T(""); //if it fails the best thing is to return nothing
    }

    lRet = RegQueryValueEx(hKey,strKeyName , NULL, NULL,(LPBYTE)szData,
&dwBufLen);

     if(lRet == ERROR_SUCCESS)
    {
     RegCloseKey(hKey);
     return szData;
    }
    else
    {
        RegCloseKey(hKey);
        return _T("");
    }

}

So with all this said, I have the following questions that I am unsure
of;

Do you see anything wrong with any of the code above? Am I missing
something simple?

When should I use the CWinApp* pApp = AfxGetApp(); followed by the
calls for GetProfileString and GetProfileInt and when should I use the
theApp.GetProfileString(....) calls or my own functions?

Thanks,
Chris
MS Alumni

Joseph M. Newcomer wrote: