Re: Pointer to my dialog

From:

=?Utf-8?B?WWFlbA==?= <Yael@discussions.microsoft.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Mon, 28 May 2007 07:41:01 -0700

Message-ID:

<5F227092-4901-41A2-B516-FE01DC58689E@microsoft.com>

I'm sorry Joseph,
you are help me alot, my english is't so good,
I'm not develop in mfc, I'm develop in c#.
I did't writ all my mfc project so I don't wriely know if it modless or
model or add dialog, I was tied your code ant else..
Thank's alot, I'm prish your unswers to me :)
Have a good day!!!
Yael.

"Joseph M. Newcomer" wrote:

See below...
On Sun, 27 May 2007 02:35:02 -0700, Yael <Yael@discussions.microsoft.com> wrote:

I'm OK, it's working to me now:
int nResponse;
//CListViewDlg * pDlg; // as memmber of this class
if ( pDlg )
{
// Restore the dialog
pDlg->ShowWindow( SW_SHOW );

//these lines not working to me.. how can I set focuse to this dialog?

*****
Define "not working". It seems obvious to me that they are not working because they are
commented out. But there is no such thing as "not working", there is a detailed
description of exactly what was expected and what was observed,

I suspect that what you are getting are assertion errors (repeat: there is NO SUCH
DESCRIPTION OF A PROBLEM that in its entirety says "this did not work" or any syntactic
variant of that phrase). The reason you are getting assertion errors is that you did not
implement the code I gave, but implemented some other random code, and consequently are
getting the wrong result.
****

//pDlg->SetFocus();
      //if(!pDlg->IsWindowVisible())
            // pDlg->ShowWindow(SW_SHOW);
       // if(pDlg->IsMinimized(pDlg->m_hWnd))
         // pDlg->ShowWindow(SW_RESTORE);
}
else
{
     pDlg = new CListViewDlg();
    nResponse = pDlg->DoModal();

*****
Exactly what part of A MODAL DIALOG IS NOT THE SOLUTION TO YOUR PROBLEM do you fail to
comprehend? You stated a problem. I, and everyone else who answered, explained, several
times, and in as many ways as possible, that a modal dialog was the wrong solution.
Nonetheless, you persist in using a modal dialog. The code I gave WILL NOT WORK if a
modal dialog is involved, and I very carefully did NOT use DoModal anywhere, so I'm
curious why you keep using it. If you want a modal solution, then your problem statement
is erroneous, and if your problem statement is corret, a modal solution is erroneous.

None of the code you added makes any sense with a modal dialog, and should be removed if
you want a modal solution. I gave a modeless dialog solution; you implemented 90% of it,
but the absolutely most crucial part of the solution, the actual creation of a modeless
dialog, you ignored, and replaced it with a call to DoModal, which makes all the rest of
the code somewhere between irrelevant and erroneous.
*****

}

CString str;
str.Format("%d",nResponse);

// Handle the return value from DoModal

*****
There is no response from DoModal because THERE IS NOT SUPPOSED TO BE A DoModal!!!!! Did
you see a DoModal call in the code I showed? No? Maybe this is because I gave you a
modeless solution, which is what you have been asking for! So FORGET DoModal. Or restate
your problem so there is some hope of understanding what you are asking for!
*****

switch ( nResponse )
{
case IDOK:// yes btn
{
OnRun();
pDlg = NULL;

****
This, of course, is a seroius mistake. It is a mistake for several reasons. First, and
please try to comprehend this, A MODAL DIALOG IS THE WRONG SOLUTION TO YOUR PROBLEM. You
stated that you wanted a dialog you could show and hide. I gave you that (except for the
details of using the tooling that it is expected that you understand).

So either you have stated your question badly, and you want a modal solution, or you want
what you asked for, in which case a modal solution is wrong.
*****

break;
}
default:
{
pDlg = NULL;

****
This is nonsensical for a modeless dialog.
****

break;
}
};

"Joseph M. Newcomer" wrote:

Let's look at the problem...
On Fri, 25 May 2007 23:58:00 -0700, Yael <Yael@discussions.microsoft.com> wrote:

Hi,
I have my dialog inherit CDialod.
in the app I'm calling this dialog:
MyDialog dlg;
dlg.DoModal();

****
This says "Create a new instance of the dialog and show it".
****

I have a problem:
if I minimized my dialog(or not),and calling to this method agein..I get new
dialog and I still have the prev dialog (in minimized..)

*****
Well, mostly because that is exactly what you told it to do. This leads to some questions
such as "how do you get another modal dialog to come up if you already have a modal dialog
minimized"? As in previous discussions of this problem it seems that you would be MUCH
better off with a modeless dialog instead of a modal dialog
*****

for example:
in the start I call: OnStart() --> CreateDlg()
In the taskbar I have an Icon, right click --> I get menu, there I have
option to check now..for showing a dialog.
then I call to OnCheckNow() (from menu options) --> CreateDlg()
now I have 2 dialogs
CreateDlg()
{
CMyDlg dlg() ;
int nResponse = dlg.DoModal();
}

****
Having created the modal dialog, how is it possible to have the menu items active?
Invoking a modal dialog means that the main application window is disabled. You are
obviously missing showing us a lot of critical code here.

I presume your function is not called "CreateDlg" but is more likely written as
void CMyMainWindow::CreateDlg()
if it is not, that could be a lot of your problem right there.
*****

OnStart()
{
CreateDlg();
}

OnCheckNow()
{
CreateDlg();
}

****
And again, this is probably
void CMyMainWindow::OnCheckNow()
which again leads to the question of how it is possible to do ANYTHING from your main
window once the modal dialog is running. Please explain
*****

I only want one dialog, have the creating functions check to see if it has
already been created; store it in a pointer or something.

****
This is why we keep telling you that you want a MODELESS dialog. Forget DoModal exists
for this purpose. You would write
    CMyDlg * MyDlg;
as a member variable. In your constructor you would do
    MyDlg = NULL;

when you want to create the dialog you would do
    MyDlg = new CMyDlg;
    MyDlg->Create(CMyDlg::IDD);

now, in the OnCheckNow handler you would write

void CMyMainWindow::OnCheckNow()
    {
     if(MyDlg == NULL)
         { /* create it */
          MyDlg = new CMyDlg;
          MyDlg->Create(CmyDlg::IDD);
         } /* create it */
    else
        { /* already exists */
         if(!MyDlg->IsWindowVisible())
              MyDlg->ShowWindow(SW_SHOW);
         if(MyDlg->IsMinimized())
              MyDlg->ShowWindow(SW_RESTORE);
        } /* already exists */

In CMyDlg you will add the following handlers
    void CMyDlg::OnOK()
        {
        }
    void CMyDlg::OnCancel()
       {
       }
    void CMyDlg::OnClose()
       {
         DestroyWindow();
       }
    void CMyDlg::OnDestroy()
      {
        GetParent()->SendMessage(UWM_DIALOG_WENT_BYE_BYE);
                    DestroyWindow();
                  }

In your main window (or the window that launched it) you will add
    LRESULT CMyMainWindow::OnDialogWentByeBye(WPARAM, LPARAM)
         {
                       MyDlg = NULL;
                       return 0;
                     }

and to the message map you will add
    ON_REGISTERED_MESSAGE(UWM_DIALOG_WENT_BYE_BYE, OnDialogWentByeBye)

See my essay on message management on my MVP Tips site to see about registered window
messages.

This should solve your problems.
*****

I need to:
Add a member pointer to that class (app).

*****
You would more likely add it to the main window class, not to the app class, because you
need someone to handle the close notification you send
]******

When I create the dialog, set the pointer,
when I close the dialog, clear the pointer.

*****
See above code as to how to do this
*****

1) what is the difference between
myDialog &dlg
and
myDialog dlg

*****
The first is a reference and consequently requires an initialization.
The second is an instance of the dialog object
But you want *dlg, which is a pointer
*****

2) I don't find how to ask if the dlg already running.

::CreateDialog()
{
     if (dlg already running)
    {
         //???
    }
   else
   {
       dlg.DoModel();
   }

****
See above code, and remember, A MODAL DIALOG IS THE WRONG SOLUTION TO THIS PROBLEM!
****

}

Thanking you in anticipation!!!
Yael.

Joseph M. Newcomer [MVP]
email: newcomer@flounder.com
Web: http://www.flounder.com
MVP Tips: http://www.flounder.com/mvp_tips.htm