Re: deleting variable for playing audio results in crash

From:

Rehmet <rgnurrahmat@gmail.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Tue, 22 Apr 2008 20:43:04 -0700 (PDT)

Message-ID:

<b17d37a0-0bee-42cc-80a8-1907d7fb7164@34g2000hsf.googlegroups.com>

Thank you David and Joe,

I made a mistake on deleting,

Deleting:
if(play1->Playing!=-17891602) //the number means whether the variable
still exist or not
{
play1->ExitInstance();
delete play1;
}

it's actually, after I put breakpoints heavily, on

if(record->recording==TRUE)
    {
        record->PostThreadMessage(WM_RECORDSOUND_STOPRECORDING,0,0);
        record->PostThreadMessage(WM_RECORDSOUND_ENDTHREAD,0,0);

    }
    if(record->recording!= -17891602)
    {
        delete record;
    }

it will give me crash on:
msacm32.drv!72d12dc5()
[Frames below may be incorrect and/or missing, no symbols loaded for
msacm32.drv]

OK, David.
I have tried with your idea, unfortunately, play1-> or record-> does
not give me option on PostQuitMessage, it only gives me
PostThreadMessage, however, I find it by using ::PostQuitMessage

Since it is record that gives me that crash, these are snippets of
stop and end thread message
void RecordSound::OnStopRecording(WPARAM wp,LPARAM lp)
{
MMRESULT mmReturn = 0;

//log.WriteString("\nIn the onstop recording");

        if(!recording)
        return ;

        mmReturn = ::waveInStop(m_hRecord);

        //To get the remaining sound data from buffer
        //Reset will call OnSoundData function

        if(!mmReturn)
        {
            recording = FALSE;
            mmReturn = ::waveInReset(m_hRecord);
        }

    /**** Code has been changed ****/
    // if(!mmReturn)
    // recording = FALSE;

        Sleep(500);

            if(!mmReturn)
            mmReturn = ::waveInClose(m_hRecord);

        return ;

}

void RecordSound::OnEndThread(WPARAM wp,LPARAM lp)
{
    //log.WriteString("\nIN the onendthread");

    if(recording)
    OnStopRecording(0,0);

    ::PostQuitMessage(0);
    return ;
}

On Apr 21, 9:16 pm, "David Ching" <d...@remove-this.dcsoft.com> wrote:

"Rehmet" <rgnurrah...@gmail.com> wrote in message

news:82714253-6b5d-4464-9317-a55a07d1f9bd@l28g2000prd.googlegroups.com...

Hi Guys,

I would like to get some insights here why when I delete a variable on
playing audio which is

Initialization:
play1=new PlaySound1(this);
play1->CreateThread();

Play:
record->PostThreadMessage(WM_RECORDSOUND_STARTRECORDING,0,0);
play1->PostThreadMessage(WM_PLAYSOUND_STARTPLAYING,0,0);

Stop:
record->SuspendThread();
record->PostThreadMessage(WM_RECORDSOUND_STOPRECORDING,0,0);
play1->PostThreadMessage(WM_PLAYSOUND_STOPPLAYING,0,0);

Deleting:
if(play1->Playing!=-17891602) //the number means whether the variable
still exist or not
{
play1->ExitInstance();
delete play1;
}

it will give me crash on:

msacm32.drv!72d12dc5()

[Frames below may be incorrect and/or missing, no symbols loaded for
msacm32.drv]
kernel32.dll!7c80b683()

I looked up on the Internet , it says MSACM32.DRV responsible for
WAVEMAPPER.

Ok, since the crash didn't point me to my own code, I am still
wondering, what's wrong?

Thanks.

Just calling ExitInstance() is not enough to stop the thread. Further,
ExitInstance() should be called from it's own thread, not from another as
here. Instead, replace

play1->ExitInstance();

with something like:

play1->PostQuitMessage(0);

if play1 (which I assume is a CWinThread) has m_bAutoDelete = TRUE (which by
default it is), then it will delete itself and you shouldn't delete it
again.

-- David